Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined method "untaint" #60

Open
SamuraiDestroy opened this issue Oct 20, 2024 · 9 comments
Open

Undefined method "untaint" #60

SamuraiDestroy opened this issue Oct 20, 2024 · 9 comments

Comments

@SamuraiDestroy
Copy link

When attempting to extract the VBIOS from the latest ASUS TUF A15 FA507NV BIOS update exe, it returns the following error:
/home/SamuraiDestroy/Downloads/VBiosFinder-master/vendor/bundle/ruby/3.2.0/gems/bundler-1.17.3/lib/bundler/shared_helpers.rb:272:in search_up': undefined method `untaint' for "/home/SamuraiDestroy/Downloads/VBiosFinder-master":String (NoMethodError)

  current  = File.expand_path(SharedHelpers.pwd).untaint
                                                ^^^^^^^^
from /home/SamuraiDestroy/Downloads/VBiosFinder-master/vendor/bundle/ruby/3.2.0/gems/bundler-1.17.3/lib/bundler/shared_helpers.rb:259:in `find_file'
from /home/SamuraiDestroy/Downloads/VBiosFinder-master/vendor/bundle/ruby/3.2.0/gems/bundler-1.17.3/lib/bundler/shared_helpers.rb:251:in `find_gemfile'
from /home/SamuraiDestroy/Downloads/VBiosFinder-master/vendor/bundle/ruby/3.2.0/gems/bundler-1.17.3/lib/bundler/shared_helpers.rb:27:in `root'
from /home/SamuraiDestroy/Downloads/VBiosFinder-master/vendor/bundle/ruby/3.2.0/gems/bundler-1.17.3/lib/bundler.rb:234:in `root'
from /home/SamuraiDestroy/Downloads/VBiosFinder-master/vendor/bundle/ruby/3.2.0/gems/bundler-1.17.3/lib/bundler.rb:246:in `app_config_path'
from /home/SamuraiDestroy/Downloads/VBiosFinder-master/vendor/bundle/ruby/3.2.0/gems/bundler-1.17.3/lib/bundler.rb:273:in `settings'
from /home/SamuraiDestroy/Downloads/VBiosFinder-master/vendor/bundle/ruby/3.2.0/gems/bundler-1.17.3/lib/bundler/feature_flag.rb:21:in `block in settings_method'
from /home/SamuraiDestroy/Downloads/VBiosFinder-master/vendor/bundle/ruby/3.2.0/gems/bundler-1.17.3/lib/bundler/cli.rb:97:in `<class:CLI>'
from /home/SamuraiDestroy/Downloads/VBiosFinder-master/vendor/bundle/ruby/3.2.0/gems/bundler-1.17.3/lib/bundler/cli.rb:7:in `<module:Bundler>'
from /home/SamuraiDestroy/Downloads/VBiosFinder-master/vendor/bundle/ruby/3.2.0/gems/bundler-1.17.3/lib/bundler/cli.rb:6:in `<top (required)>'
from <internal:/usr/lib/ruby/vendor_ruby/rubygems/core_ext/kernel_require.rb>:86:in `require'
from <internal:/usr/lib/ruby/vendor_ruby/rubygems/core_ext/kernel_require.rb>:86:in `require'
from /home/SamuraiDestroy/Downloads/VBiosFinder-master/vendor/bundle/ruby/3.2.0/gems/bundler-1.17.3/exe/bundle:23:in `block in <top (required)>'
from /home/SamuraiDestroy/Downloads/VBiosFinder-master/vendor/bundle/ruby/3.2.0/gems/bundler-1.17.3/lib/bundler/friendly_errors.rb:124:in `with_friendly_errors'
from /home/SamuraiDestroy/Downloads/VBiosFinder-master/vendor/bundle/ruby/3.2.0/gems/bundler-1.17.3/exe/bundle:22:in `<top (required)>'
from /usr/bin/bundle:25:in `load'
from /usr/bin/bundle:25:in `<main>'

`

@sechmachine727
Copy link

This error occurs because the untaint method has been removed in Ruby 3.3.0, and Bundler 1.17.3 is trying to use it. To fix this, you'll need to update Bundler to a version compatible with Ruby 3.3.01. Here’s how you can do it:

Update RubyGems: Ensure RubyGems is up to date:
gem update --system

Install Bundler: Install or update Bundler to a version compatible with Ruby 3.3.0:
gem install bundler

Update Bundler: Update your project's Bundler version:
bundle update --bundler

Run Bundle Install: Finally, run bundle install again:
bundle install --path=vendor/bundle

This should resolve the issue. Does this help?

@SamuraiDestroy
Copy link
Author

gem update --system didn't work but everything else did just fine. I ran VBIOSFinder again and now the error is
`checking for ruby... yes

checking for innoextract... yes
checking for upx... no
Install 'upx' on your system (required for UPX executables)
checking for 7z... yes
trying to extract ./ASUS_FA507NV_314_BIOS_Update.exe
found zlib archive
wrong guess :(
found 7z archive
trying to extract ./BIOSInstall.ps1
trying to extract ./Cabfile/FA507NV.314
found zlib archive
wrong guess :(
trying to extract ./Cabfile/FA507NV_314.inf
trying to extract ./Cabfile/fa507nv_314.cat
trying to extract ./Install.bat
extracting uefi data
trying to extract ./ASUS_FA507NV_314_BIOS_Update.exe
Cleaning up garbage
/home/SamuraiDestroy/Downloads/VBiosFinder-master/vendor/bundle/ruby/3.2.0/gems/terrapin-0.6.0/lib/terrapin/command_line.rb:82:in run': Terrapin::CommandNotFoundError (Terrapin::CommandNotFoundError) from /home/SamuraiDestroy/Downloads/VBiosFinder-master/src/extract-uefi.rb:20:in uefi'
from /home/SamuraiDestroy/Downloads/VBiosFinder-master/src/extraction.rb:8:in call' from /home/SamuraiDestroy/Downloads/VBiosFinder-master/src/extraction.rb:8:in attempt'
from /home/SamuraiDestroy/Downloads/VBiosFinder-master/src/methods.rb:46:in block in run' from /home/SamuraiDestroy/Downloads/VBiosFinder-master/src/methods.rb:44:in each'
from /home/SamuraiDestroy/Downloads/VBiosFinder-master/src/methods.rb:44:in run' from /home/SamuraiDestroy/Downloads/VBiosFinder-master/src/cli.rb:36:in extract'
from /home/SamuraiDestroy/Downloads/VBiosFinder-master/vendor/bundle/ruby/3.2.0/gems/thor-0.20.0/lib/thor/command.rb:27:in run' from /home/SamuraiDestroy/Downloads/VBiosFinder-master/vendor/bundle/ruby/3.2.0/gems/thor-0.20.0/lib/thor/invocation.rb:126:in invoke_command'
from /home/SamuraiDestroy/Downloads/VBiosFinder-master/vendor/bundle/ruby/3.2.0/gems/thor-0.20.0/lib/thor.rb:387:in dispatch' from /home/SamuraiDestroy/Downloads/VBiosFinder-master/vendor/bundle/ruby/3.2.0/gems/thor-0.20.0/lib/thor/base.rb:466:in start'
from _init.rb:7:in <main>'
I'm assuming I don't need UPX since it's an .exe file and anyway I had trouble trying to install it.

@sechmachine727
Copy link

I could send you an upx executable, but it might be worth checking out this: #56

@SamuraiDestroy
Copy link
Author

I don't really understand #50 since it says /usr/bin/uefiextract but I don't have that. Is it somewhere inside of UEFITool?

@sechmachine727
Copy link

sechmachine727 commented Nov 6, 2024

I don't really understand #50 since it says /usr/bin/uefiextract but I don't have that. Is it somewhere inside of UEFITool?

UEFITool Repo has UEFIExtract, a separate executable. But named uefiextract (lowercase) by default. Since Linux is case sensitive so you have to rename it. But first made sure you put UEFIExtract executable in 3rdparty dir.

@SamuraiDestroy
Copy link
Author

I can't find the UEFIExtract executable, where is it?

@SamuraiDestroy
Copy link
Author

SamuraiDestroy commented Nov 7, 2024

That link just leads to a blank page.
Edit: I found the executable on the UEFITool page, going to try it again now
Edit 2: It works now! It output an exe file and a bin file though, is that supposed to happen?
Edit 3 (This is kind of getting stupid): So I'm trying to get the ROM for this since NVflash didn't work properly and it says there's supposed to be text somewhere under char that says "VIDEO" but ctrl+f says it doesnt have it. I checked both the exe and the bin file.

@sechmachine727
Copy link

Can you give me the rom file, see if I could extract it? This tool depends on luck tho. Did not extract the vbios ROM from my old laptop either (Acer Nitro 5 AN515-52 2018)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants