Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad links from expressions to interface methods when implementation uses subtype of generic parameter #109

Open
GoogleCodeExporter opened this issue Mar 4, 2015 · 1 comment

Comments

@GoogleCodeExporter
Copy link

In the following example below, Celeriac attempts to link the properties of the 
SReversedEdge parameter to the parameter of in the corresponding interface. 
However, SReversedEdge, as a subclass of IEdge, has more properties / methods.

public interface IEdgeSet<TVertex, TEdge>
  where TEdge : IEdge<TVertex>{

  bool ContainsEdge(TEdge edge);
}

public sealed class ReversedBidirectionalGraph<TVertex, TEdge> : 
  IBidirectionalGraph<TVertex,SReversedEdge<TVertex,TEdge>>
  where TEdge : IEdge<TVertex>

  public bool ContainsEdge(SReversedEdge<TVertex, TEdge> edge)
  {
     ...
  }
}

Original issue reported on code.google.com by [email protected] on 14 Jun 2013 at 3:46

@GoogleCodeExporter
Copy link
Author

Add a conservative fix in 79894216e4b0; basically parameters and return values 
are only linked if they refer to the same type (so generic parameters / return 
values won't be linked in most cases).

Original comment by [email protected] on 14 Jun 2013 at 4:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant