Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to choose between the stable and git master versions of Codespell #5

Open
peternewman opened this issue May 26, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@peternewman
Copy link
Collaborator

Looks like it should be possible by passing args into the Dockerfile
https://help.github.com/en/actions/creating-actions/creating-a-docker-container-action#creating-an-action-metadata-file
And here:
https://docs.docker.com/engine/reference/builder/

@cclauss
Copy link
Contributor

cclauss commented Mar 29, 2023

Is this task complete?

@peternewman
Copy link
Collaborator Author

Is this task complete?

I don't believe so, we still just load them in via requirements.txt which specifies a tagged version currently:
https://github.com/codespell-project/actions-codespell/blob/master/requirements.txt

@cclauss
Copy link
Contributor

cclauss commented Mar 30, 2023

There are two packages published…

image

@peternewman
Copy link
Collaborator Author

There are two packages published…

They're built by the two workflows here:
https://github.com/codespell-project/actions-codespell/tree/master/.github/workflows

They are stable and master versions of the action, rather than of codespell. The master one is built weekly with any commits in the master branch and the latest release version of codespell at that point in time. The stable version is built whenever there's a tag made, with the latest release version of codespell at that time.

Although TBH I'm unclear how you use either of those rather than the normal action script...

@cclauss
Copy link
Contributor

cclauss commented Mar 30, 2023

  • uses: codespell-project/actions-codespell@v1
  • uses: codespell-project/actions-codespell@stable
  • uses: codespell-project/actions-codespell@master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants