-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
option(s) to submit fixes #68
Comments
Hmm. Certainly doable from the
and etc. So it'd just be a matter of ...Arguably that functionality may be out of scope for this action, though, because it's "codespell with annotations" — and there's no real point in making annotations for spelling errors that are automatically fixed. It's kind of taking things in a different direction, functionality-wise. A separate action to run codespell and auto-apply the changes, instead of making annotations, might actually make more sense, despite the seeming redundancy of two different actions to run codespell. (In truth there are multiple codespell actions already, so adding an "auto-apply codespell fixes" action would just be expanding the existing set of choices.) |
IMHO there is no need for a separate action and indeed could be just a matter of adding an option and committing/pushing. FWIW, here is a "live" fresh request for such a feature
|
@yarikoptic |
Would it be enough to allow I also wonder if it's easier instead to use |
but pushing from CI is easy for a PR, isn't it? people who use pre-commit.ci typically do not even wan to use actions-codespell since they have codespell in their pre-commit config. |
For a PR it would be a commit to the same branch. (we do similar for adding changelog entries to PRs upon a specific label being present: https://github.com/datalad/release-action/blob/master/add-changelog-snippet/action.yml#L23 )
For a run within a non-PR branch - would be a new PR against that branch.
The text was updated successfully, but these errors were encountered: