Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warnings thrown in CI #3

Closed
kurtmckee opened this issue Jul 25, 2023 · 6 comments · Fixed by #5
Closed

Deprecation warnings thrown in CI #3

kurtmckee opened this issue Jul 25, 2023 · 6 comments · Fixed by #5

Comments

@kurtmckee
Copy link

A new version needs to be released to support Node 16. The code appears to be in place already, so all that seems to be needed is a new version.

Other projects are seeing warnings in CI caused by the v1 tag still requiring Node 12, which is no longer available. Here's a recent example from codespell's CI.

I don't have a recommendation whether this should be a new v1 or should jump to v2, but a new version is needed.

@DimitriPapadopoulos
Copy link
Collaborator

node12

@DimitriPapadopoulos
Copy link
Collaborator

@DimitriPapadopoulos
Copy link
Collaborator

I'll bump from node16 to node20 before trying to prepare a v2, so that it lasts longer.

@kurtmckee
Copy link
Author

Friendly ping. 😀

@DimitriPapadopoulos
Copy link
Collaborator

@kurtmckee The version has been bumped from node16 to node20 in #5, and is part of v1.2.0. What would be missing?

@kurtmckee
Copy link
Author

Ah, I had thought that this was only to be released with v2 based on the above discussion.

Only thing missing is for me to close this issue! 😀 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants