Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ruby] Add strings #426

Closed
geekygirlsarah opened this issue Oct 31, 2021 · 25 comments · Fixed by #555
Closed

[Ruby] Add strings #426

geekygirlsarah opened this issue Oct 31, 2021 · 25 comments · Fixed by #555
Assignees
Labels
Experience: Language Concept Thesaurus data for comparing languages good first issue A good issue for anyone new to open source to work on hacktoberfest Good issue for someone to work on for Hacktoberfest help wanted We'd love to have help working on this issue Language: Ruby Type: Enhancement

Comments

@geekygirlsarah
Copy link
Member

geekygirlsarah commented Oct 31, 2021

Description

Strings for Ruby aren't presently on Code Thesaurus. This issue is to add that concept to the system.

Directions

  • On the home page, on the right side (the reference sheet side), choose the language and version, and then the concept.
  • The page says the data doesn't exist, but clicking the arrow for the template will provide the template and file for you to use.
  • Save that file in /web/thesauruses/[language]/[version]/[concept].json.
  • Fill out all of the "code" sections.
  • Add in "not-implemented": "true" if the concept doesn't exist in the language. You can then delete the "code" line.
  • Add in "comment": if you wish to explain something in the code
  • Delete the "name": fields before your PR
  • Save, commit your code, push to your fork, then make a PR.
  • Watch the checks to make sure they all pass. If they don't, click on "Details" and it should tell you what to modify.

Claiming This Issue

Please leave a comment below so I can assign you to it. This is to prevent multiple people from working on the same issue.

Check out CONTRIBUTING.md for more information on how to contribute.

Check out https://docs.codethesaur.us/thesaurus/ for information on how Code Thesaurus works and how to add to the thesauruses.

Need Help?

Leave a comment on here with your question, or feel free to ask @geekygirlsarah on Twitter. You can also email [email protected] too.

Thanks!

We really value and appreciate the additions people make to Code Thesaurus, no matter how large or small. So thank you for taking the time to work on this!

@geekygirlsarah geekygirlsarah added help wanted We'd love to have help working on this issue good first issue A good issue for anyone new to open source to work on hacktoberfest Good issue for someone to work on for Hacktoberfest Experience: Language Concept Thesaurus data for comparing languages labels Oct 31, 2021
@opeco17
Copy link
Contributor

opeco17 commented Nov 3, 2021

Hi, @geekygirlsarah
I would like to contribute to Code Thesaurus
Could you please assign this to me?

@geekygirlsarah
Copy link
Member Author

I'll give you this one too! Let me know if you have any questions!

@geekygirlsarah geekygirlsarah removed the hacktoberfest Good issue for someone to work on for Hacktoberfest label Nov 6, 2021
@geekygirlsarah
Copy link
Member Author

Hey @opeco17, how is this coming along? I haven't seen any updates and it's been over 3 weeks now. If you still want the issue, let me know otherwise I'll probably unassign you. And if you have any questions, let me know too!

@geekygirlsarah
Copy link
Member Author

Haven't heard back so I'm removing them. (If you still want it, let me know and I'll add you back.)

@geekygirlsarah geekygirlsarah added hacktoberfest Good issue for someone to work on for Hacktoberfest and removed Priority: Low labels Sep 17, 2022
@geekygirlsarah geekygirlsarah changed the title Add Ruby strings [Ruby] Add strings Oct 2, 2022
@pulgamecanica
Copy link
Contributor

Hello, I would like to contribute to solving this issue.
I am an enthusiastic Ruby developer and would like to try it very much.
This project is very awesome and I like the website a lot.
I have read the Documentation and especially I read carefully the "Contributing" section but if you have any other tips I am interested in having a look before trying it.

Best regards,
André

@pulgamecanica
Copy link
Contributor

I also have a suggestion, in case you haven't considered it.
Perhaps, the JSON should have another section to add the references. I love references, to confirm the information, or if someone wants to dig deeper about a certain subject...
Cheers :)

@geekygirlsarah
Copy link
Member Author

Hey @pulgamecanica, I'll assign you then! And yeah, let me know if you have any questions.

And I suppose great minds think alike, there's #188 for the references.

@pulgamecanica
Copy link
Contributor

Thank's I'll give my best and I will try to be consistent :D

@pulgamecanica
Copy link
Contributor

Hello!

Today I will be working on the JSON, yesterday I was able to run the docker-compose without many issues, I worked with Django before and I was happy to see it again, so without further ado, I will do my best and I will use "The Well Grounded Rubyist" 📖 as a reference to get all the ideas straight and without much complications for any reader! :D ✏️

@pulgamecanica
Copy link
Contributor

pulgamecanica commented Oct 4, 2022

Screen Shot 2022-10-04 at 13 08 23

I'm ready to goooo, eager to finish. Again, thanks a lot for letting me contribute, this is so cool!

@geekygirlsarah
Copy link
Member Author

I'm glad you're so excited @pulgamecanica ! I hope you have some fun with it, maybe learn some new things along the way. Again, let me know if you have any questions!

@pulgamecanica
Copy link
Contributor

I have finished, I will perform now a PR :D

I also found one little tiny typo which I would love to fix :D not sure if I should create an issue for it though...
The typo is here:
https://codethesaur.us/reference/?concept=strings&lang=java%3B17
It's because they forgot to escape the backslash so it actually created a new line instead of showing the new line character.


IMG showing the exact typo:

Screen Shot 2022-10-04 at 18 15 14

@pulgamecanica pulgamecanica mentioned this issue Oct 4, 2022
4 tasks
@geekygirlsarah
Copy link
Member Author

I also found one little tiny typo which I would love to fix :D not sure if I should create an issue for it though... The typo is here: https://codethesaur.us/reference/?concept=strings&lang=java%3B17 It's because they forgot to escape the backslash so it actually created a new line instead of showing the new line character.

Good catch! You can sneak it into #555 if you want or you can make a new PR. (no issue needed)

@pulgamecanica
Copy link
Contributor

pulgamecanica commented Oct 4, 2022

Overall it was very nice to do it, but I couldn't find a proper answer for the second question, so I entered "no need?" because I really didn't know what to put.

Screen Shot 2022-10-04 at 18 29 22

So if you know what I could put there to make it understandable for the readers, I would appreciate it. The string is built.in class which comes along all the Modules for Ruby so it is included by default, I don't know how to explain this very well.

@pulgamecanica
Copy link
Contributor

I closed the PR because I didn't want the "No need?" to go there haha I forgot about it... only now I realized

@geekygirlsarah
Copy link
Member Author

Oh you don't have to close and open a new one. Just push new changes. Github updates it automatically.

@pulgamecanica
Copy link
Contributor

I will sneak that fix for the Java lang on the PR 😄
Well then, I'll do that.

@geekygirlsarah
Copy link
Member Author

Want me to reopen #555 then? You can edit the text of the PR too if something changes.

@pulgamecanica
Copy link
Contributor

I would appreciate that, thank you.

@pulgamecanica
Copy link
Contributor

Ohhh wow.... that's so nice, it really did it automatically.... now it shows the 4 files changed on the PR.
That's so cool.

@pulgamecanica
Copy link
Contributor

Now it says: "Built-in included in the default Modules" instead of "No need? ✅

@pulgamecanica
Copy link
Contributor

pulgamecanica commented Nov 23, 2022

Srry for not updating this, I'll see how I can finish this soon!

Wrong issue... I meant it for the Ruby operators...
Cheers.

@geekygirlsarah
Copy link
Member Author

That's alright! (You can always delete comments too)

@pulgamecanica
Copy link
Contributor

I don't like much to delete comments because you might recieve an email about someone saying something and then you can never find it hahaha

@geekygirlsarah
Copy link
Member Author

Alright, that's fair too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Experience: Language Concept Thesaurus data for comparing languages good first issue A good issue for anyone new to open source to work on hacktoberfest Good issue for someone to work on for Hacktoberfest help wanted We'd love to have help working on this issue Language: Ruby Type: Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants