-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ruby] Add strings #426
Comments
Hi, @geekygirlsarah |
I'll give you this one too! Let me know if you have any questions! |
Hey @opeco17, how is this coming along? I haven't seen any updates and it's been over 3 weeks now. If you still want the issue, let me know otherwise I'll probably unassign you. And if you have any questions, let me know too! |
Haven't heard back so I'm removing them. (If you still want it, let me know and I'll add you back.) |
Hello, I would like to contribute to solving this issue.
|
I also have a suggestion, in case you haven't considered it. |
Hey @pulgamecanica, I'll assign you then! And yeah, let me know if you have any questions. And I suppose great minds think alike, there's #188 for the references. |
Thank's I'll give my best and I will try to be consistent :D |
Hello! Today I will be working on the JSON, yesterday I was able to run the docker-compose without many issues, I worked with Django before and I was happy to see it again, so without further ado, I will do my best and I will use "The Well Grounded Rubyist" 📖 as a reference to get all the ideas straight and without much complications for any reader! :D ✏️ |
I'm glad you're so excited @pulgamecanica ! I hope you have some fun with it, maybe learn some new things along the way. Again, let me know if you have any questions! |
I have finished, I will perform now a PR :DI also found one little tiny typo which I would love to fix :D not sure if I should create an issue for it though... IMG showing the exact typo: |
Good catch! You can sneak it into #555 if you want or you can make a new PR. (no issue needed) |
Overall it was very nice to do it, but I couldn't find a proper answer for the second question, so I entered "no need?" because I really didn't know what to put. So if you know what I could put there to make it understandable for the readers, I would appreciate it. The string is built.in class which comes along all the Modules for Ruby so it is included by default, I don't know how to explain this very well. |
I closed the PR because I didn't want the "No need?" to go there haha I forgot about it... only now I realized |
Oh you don't have to close and open a new one. Just push new changes. Github updates it automatically. |
I will sneak that fix for the Java lang on the PR 😄 |
Want me to reopen #555 then? You can edit the text of the PR too if something changes. |
I would appreciate that, thank you. |
Ohhh wow.... that's so nice, it really did it automatically.... now it shows the 4 files changed on the PR. |
Now it says: "Built-in included in the default Modules" instead of "No need? ✅ |
Srry for not updating this, I'll see how I can finish this soon! Wrong issue... I meant it for the Ruby operators... |
That's alright! (You can always delete comments too) |
I don't like much to delete comments because you might recieve an email about someone saying something and then you can never find it hahaha |
Alright, that's fair too! |
Description
Strings for Ruby aren't presently on Code Thesaurus. This issue is to add that concept to the system.
Directions
/web/thesauruses/[language]/[version]/[concept].json
."code"
sections."not-implemented": "true"
if the concept doesn't exist in the language. You can then delete the"code"
line."comment":
if you wish to explain something in the code"name":
fields before your PRClaiming This Issue
Please leave a comment below so I can assign you to it. This is to prevent multiple people from working on the same issue.
Check out CONTRIBUTING.md for more information on how to contribute.
Check out https://docs.codethesaur.us/thesaurus/ for information on how Code Thesaurus works and how to add to the thesauruses.
Need Help?
Leave a comment on here with your question, or feel free to ask @geekygirlsarah on Twitter. You can also email [email protected] too.
Thanks!
We really value and appreciate the additions people make to Code Thesaurus, no matter how large or small. So thank you for taking the time to work on this!
The text was updated successfully, but these errors were encountered: