Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Javascript] Add input/output #595

Closed
ulyssear opened this issue Oct 17, 2022 · 4 comments · Fixed by #607
Closed

[Javascript] Add input/output #595

ulyssear opened this issue Oct 17, 2022 · 4 comments · Fixed by #607
Assignees
Labels
Experience: Language Concept Thesaurus data for comparing languages good first issue A good issue for anyone new to open source to work on hacktoberfest Good issue for someone to work on for Hacktoberfest help wanted We'd love to have help working on this issue Language: JavaScript

Comments

@ulyssear
Copy link
Contributor

Description

Add "input/output" concept for javascript (ECMAScript 2009, 2020, 2021 and 2023)

Directions

Same directions than issues about adding a concept (#583 for example).

Additional Information

I can work on this issue. As I started Hacktoberfest with this repository, I'm enjoying it ^^

@geekygirlsarah
Copy link
Member

Sounds good @ulyssear, I'll assign you!

@geekygirlsarah geekygirlsarah added help wanted We'd love to have help working on this issue good first issue A good issue for anyone new to open source to work on hacktoberfest Good issue for someone to work on for Hacktoberfest Experience: Language Concept Thesaurus data for comparing languages Language: JavaScript labels Oct 17, 2022
@ulyssear
Copy link
Contributor Author

ulyssear commented Oct 18, 2022

I began the issue today and I'm confused about some points (see below).

image

Firstly, JavaScript syntax highlighting is either uninteresting or incomprehensible.
In the screenshot shown, only two keywords are colored ("const" and "delete"), and the "delete" method, due to the keyword, is the only method colored.
A new issue may be created to deal with this.

image

Lastly, JavaScript has a native method for manipulating WebSockets. However, these are not network sockets. Do I put code snippets about WebSockets? Otherwise, we can add a Node.js module dealing with network sockets (net module for example).

Thanks in advance for your answer! :)

@cafce25
Copy link
Contributor

cafce25 commented Oct 18, 2022

You're right about the highlighting but I think it's hard to get better automated highlighting cause the snippets of code are so short and there is almost no context. Although your string is highlighted as well, but since we're just using the default pygments colorscheme that's barely noticeable.

I've created #602 to track the syntax issue

I think websockets should go into their own concepts, network sockets here refer to bare tcp/ip sockets.
Since there are no concepts about websockets yet you'd need to create new ones in the meta file first. Then you can just use your newly created keys.
You can either add them into the "Network IO" category or just create a new one, your choice if you decide to add them.

@geekygirlsarah
Copy link
Member

geekygirlsarah commented Oct 18, 2022

For the syntax highlighting, aside from fixing it in the Pygments project or finding a new highlighter, I'm not sure what we can do. I definitely do NOT recommend making a new highlighter, lol.

As for Websockets, I think it crossed my mind but I dismissed it thinking it was only a JavaScript thing, but I guess you implement the other side in whatever language you want. So yeah, I could see it becoming a new IO section in the meta file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Experience: Language Concept Thesaurus data for comparing languages good first issue A good issue for anyone new to open source to work on hacktoberfest Good issue for someone to work on for Hacktoberfest help wanted We'd love to have help working on this issue Language: JavaScript
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants