Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme #719

Open
God-damnit-all opened this issue Feb 11, 2024 · 2 comments
Open

Dark theme #719

God-damnit-all opened this issue Feb 11, 2024 · 2 comments
Labels
Experience: Frontend Experience: UX good first issue A good issue for anyone new to open source to work on hacktoberfest Good issue for someone to work on for Hacktoberfest help wanted We'd love to have help working on this issue Type: Enhancement

Comments

@God-damnit-all
Copy link

Description

There should be a button that switches the site between a light theme and a dark theme, with its default state set by something akin to window.matchMedia('(prefers-color-scheme: dark)')

Requirements

A white flash of light (a "flashbang") often occurs on pages that have toggleable themes before dark mode can be applied. There are ways to avoid this, described in the "Loading strategy" section of this reputable article.

Additional Notes

Let's be real, a site for coders should always have a dark theme.

@geekygirlsarah geekygirlsarah added Type: Enhancement Experience: Frontend Experience: UX help wanted We'd love to have help working on this issue good first issue A good issue for anyone new to open source to work on labels Feb 11, 2024
@geekygirlsarah
Copy link
Member

Hmm... I'll consider this. There's some things to adjust with the code highlighting to make sure it works, I think.

On a side note, Though as a coder that built a site for coders, I'll admit I bounce back and forth between them depending on mood, time of day, whether I'm presenting to people or not, etc. Sometimes dark mode is actually worse, I think.

Also why'd you point out that the article is reputable?

@God-damnit-all
Copy link
Author

Hmm... I'll consider this. There's some things to adjust with the code highlighting to make sure it works, I think.

On a side note, Though as a coder that built a site for coders, I'll admit I bounce back and forth between them depending on mood, time of day, whether I'm presenting to people or not, etc. Sometimes dark mode is actually worse, I think.

Also why'd you point out that the article is reputable?

Have you seen the results on search engines lately?

@geekygirlsarah geekygirlsarah added the hacktoberfest Good issue for someone to work on for Hacktoberfest label Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Experience: Frontend Experience: UX good first issue A good issue for anyone new to open source to work on hacktoberfest Good issue for someone to work on for Hacktoberfest help wanted We'd love to have help working on this issue Type: Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants