Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cyclic handling and resolve bug #63206 in error and exception han… #60

Conversation

pavelzotikov
Copy link
Contributor

This PR addresses several key improvements in the error and exception handling flow, specifically resolving cyclic error handling issues and fixing bug #63206. The following changes have been made:

  1. Cyclic Error Prevention: The logic has been updated to prevent infinite loops by ensuring that an exception previously handled by a custom handler is properly delegated back to the native PHP handler if it matches the current exception.
  2. Bug #63206: A fix for bug #63206 was implemented, which caused issues with error reporting duplication and cyclic behavior in the error handling process.
  3. Fatal Error Handler Disablement: Adjusted the fatal error handler to prevent errors from being reported twice in cases of shutdown errors.
  4. Improved Context Handling: Refined the context merging logic to ensure all event data is properly processed before sending.

These improvements enhance the robustness of the SDK, preventing redundant error reporting and ensuring proper exception handling flow.

@pavelzotikov pavelzotikov merged commit 654dc0a into codex-team:master Sep 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants