Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add POST /note/:notePublicId/relation route #260

Merged
merged 7 commits into from
Jun 30, 2024

Conversation

kloV148
Copy link
Contributor

@kloV148 kloV148 commented Jun 30, 2024

This creates a relation for an already existing note. We use it when we want to set parent note for an existing note.
Also, tests added for this route

Copy link

github-actions bot commented Jun 30, 2024

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 86.19% (🎯 80%)
⬆️ +0.13%
7653 / 8879
🟢 Statements 86.19% (🎯 80%)
⬆️ +0.13%
7653 / 8879
🔴 Functions 79.53% (🎯 80%)
⬆️ +0.06%
241 / 303
🟢 Branches 85.96% (🎯 80%)
⬆️ +0.15%
386 / 449
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/domain/service/note.ts 96.16% 86.95% 100% 96.16% 75-76, 102-103, 109-110, 125-126, 147-148, 235-236
src/presentation/http/router/note.ts 98.31% 85.18% 100% 98.31% 144-145, 610-611, 627-633
Generated in workflow #748

@kloV148 kloV148 requested a review from slaveeks June 30, 2024 13:54
src/domain/service/note.ts Outdated Show resolved Hide resolved
src/presentation/http/router/note.ts Outdated Show resolved Hide resolved
@kloV148 kloV148 requested a review from e11sy June 30, 2024 16:30
@kloV148 kloV148 merged commit 07e5e4a into main Jun 30, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants