-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parent structure): add method that return note parent structure #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
File Coverage
|
e11sy
requested changes
Aug 29, 2024
e11sy
requested changes
Sep 3, 2024
e11sy
reviewed
Sep 6, 2024
you can also patch Good job, almost done! |
…by adding note parrent structure
resolve #275 |
e11sy
reviewed
Sep 10, 2024
neSpecc
requested changes
Sep 13, 2024
… a test, tests work in progress
e11sy
reviewed
Sep 15, 2024
neSpecc
reviewed
Sep 16, 2024
…in tests instead of individual test cases
e11sy
reviewed
Sep 28, 2024
e11sy
reviewed
Oct 3, 2024
neSpecc
requested changes
Oct 3, 2024
neSpecc
reviewed
Oct 15, 2024
e11sy
requested changes
Oct 16, 2024
neSpecc
approved these changes
Oct 16, 2024
e11sy
approved these changes
Oct 16, 2024
neSpecc
reviewed
Oct 16, 2024
…rder, add related test to this case
slaveeks
reviewed
Oct 21, 2024
neSpecc
reviewed
Oct 24, 2024
neSpecc
approved these changes
Oct 24, 2024
slaveeks
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
First task in issue #275, make a method to return recursively note parent structure.
Resolves #275
Solution:
Return an array of note parent structure on the following form:
Making sure that the user has access to each note parent before including them in the returned array.