Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme): ensure Roboto font is applied correctly on button #19

Closed
wants to merge 1 commit into from
Closed

fix(theme): ensure Roboto font is applied correctly on button #19

wants to merge 1 commit into from

Conversation

ishaan000
Copy link
Collaborator

  • Remove "Arial, sans-serif" from fontFamily

Reason for change :

  • While working on the not-found page, I noticed that the Roboto font was not being applied to Button atom.
  • Removing the extra font styles in Theme.ts fixed the bug.

@ishaan000
fix(theme): ensure Roboto font is applied correctly on button
4cdfcb8 
- Remove "Arial, sans-serif" from fontFamily
@ishaan000 ishaan000 added bug Something isn't working components Related to React components styles Related to code formatting, styles, and linting. labels Nov 6, 2024
@ishaan000 ishaan000 requested a review from hiyaryan November 6, 2024 17:42
@ishaan000 ishaan000 self-assigned this Nov 6, 2024
@ishaan000 ishaan000 closed this Nov 7, 2024
@ishaan000
Copy link
Collaborator Author

Not needed anymore, we want to keep Fonts to fall back on. Finding a different fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiyaryan hiyaryan Awaiting requested review from hiyaryan

Assignees

@ishaan000 ishaan000

Labels
bug Something isn't working components Related to React components styles Related to code formatting, styles, and linting.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ishaan000