Support for ImageVector

[yschimke]

I'm curious if there is a reason that ImageVector is not supported?

coil/coil-compose-base/src/main/java/coil/compose/AsyncImagePainter.kt

Line 388 in 70300e5

is ImageVector -> unsupportedData("ImageVector")

Seems like a useful variant of the data type which is Any?.

[colinrtwhite]

It’s unsupported as you can render an ImageVector using Image directly.

[yschimke]

OK, makes sense. We have a reusable Chip, that takes Any? as the image data. It seemed unfortunate that we need to put the if statement in our code.

https://github.com/google/horologist/pull/330/files#diff-7c9f44c939721cf07ca16348362c65198ae1a117ca16cdb55c30306af24e38e9

Is it a performance related thing? Using Image a vastly simpler codepath?

But not going to argue it, just curious.

[colinrtwhite]

I believe it was initially added when coil-compose was part of Accompanist. I think it was mostly to avoid folks accidentally attempting to load ImageVector/ImageBitmap as those will fail to load without a custom Fetcher (basic ImageLoaders only understand VectorDrawable/Bitmap/BitmapDrawable). I agree it’s a little awkward with the if/else, but the alternative is adding custom fetchers (and removing the require). I’m not 100% opposed to removing the require. What do you think?

[yschimke]

Your call.

I'd prefer the custom fetcher, so it really is Any?. But maybe that's an antipattern for performance, when those ImageVectors should almost always just be Image.

[colinrtwhite]

I think we should leave it as is then. Can always revisit it later if necessary!