Failure on Plone 4.3: "NameError: name 'FolderView' is not defined"

[adaugherity]

This affects Solgema.fullcalendar 2.3.5 and 2.3.6; if I pin it to 2.3.4 everything is fine. Running on Plone 4.3.7.

With these versions, Zope fails to start; here is the relevant output of bin/client1 fg:

  File "/opt/plone4/buildout-cache/eggs/Solgema.fullcalendar-2.3.6-py2.7.egg/Solgema/fullcalendar/browser/views.py", line 172, in <module>
    class SolgemaFullcalendarDxView(FolderView, SolgemaFullcalendarView):
zope.configuration.xmlconfig.ZopeXMLConfigurationError: File "/opt/plone4/plone4_dev/parts/client1/etc/site.zcml", line 16.2-16.23
    ZopeXMLConfigurationError: File "/opt/plone4/buildout-cache/eggs/Products.CMFPlone-4.3.7-py2.7.egg/Products/CMFPlone/configure.zcml", line 98.4-102.10
    ZopeXMLConfigurationError: File "/opt/plone4/buildout-cache/eggs/Solgema.fullcalendar-2.3.6-py2.7.egg/Solgema/fullcalendar/configure.zcml", line 24.2-24.31
    ZopeXMLConfigurationError: File "/opt/plone4/buildout-cache/eggs/Solgema.fullcalendar-2.3.6-py2.7.egg/Solgema/fullcalendar/browser/configure.zcml", line 21.2-29.8
    NameError: name 'FolderView' is not defined

Looking at recent commits, it appears there was work done with folder views that uses plone.app.contenttypes, which I do not have in my buildout. Is that a dependency of Solgema.fullcalendar now, or is the "don't have p.a.contenttypes" code path broken?

[pgrunewald]

Experiencing the same issue. I guess that this commit introduced a hidden dependency to plone.app.contenttypes >= 1.1.x. This will break for all Plone 4.x sites that make no use of Dexterity whatsoever.

Maybe @bsuttor can give some insight for this issue?

[bsuttor]

Indeed, It seems my commit was a little to early.

Maybe adding a zmcl:condition like this will fix it ?

<browser:page zcml:condition="installed plone.app.contenttypes"
       for="plone.app.contenttypes.interfaces.IFolder"
       name="solgemafullcalendar_view"

[pgrunewald]

Good thinking, but it's unfortunately not the solution. The file view.py is also included by other browser:page/ statements. Those specific folder and collections views probably should be migrated into dx.py, which is already constrained by the existence of Dexterity.

Update: Migrated the relevant code into dx.py. It is still imported, since plone.dexterity seems to be present anyway in Plone 4.x. So I guess, we need do split the view classes more finegrained into separate files.