Refactor embed Consumer Utility error handling to fix YouTube tests #97
Labels
Comments
idgserpro
added a commit
that referenced
this issue
Jan 5, 2021
Skipping: test_unauthorized_request, test_url_not_found More information can be found in #97
hvelarde
added a commit
that referenced
this issue
Jan 6, 2021
* Fix error 403 for Youtube oembed endpoint (Ref. #95). * Update CHANGES.rst * Fix test_youtube_oembed; Skip some tests. Skipping: test_unauthorized_request, test_url_not_found More information can be found in #97 Co-authored-by: Héctor Velarde <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After #95, we discovered that the Oembed Consumer Utility error handling needs to be improved, since Youtube returns a html page instead of a well formed json if the video is Unauthorized or Not Found (
sc.embedder/src/sc/embedder/utility.py
Line 43 in c5d1eef
A more detailed explanation about this whole situation can be found in #96 (comment).
Since the embed functionality for Youtube embed is completely broken, these refactoring and the tests will be fixed later.
The text was updated successfully, but these errors were encountered: