Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSP Support for Kotlin modules #3606

Closed
lihaoyi opened this issue Sep 26, 2024 · 3 comments
Closed

BSP Support for Kotlin modules #3606

lihaoyi opened this issue Sep 26, 2024 · 3 comments

Comments

@lihaoyi
Copy link
Member

lihaoyi commented Sep 26, 2024

Splitting this out of #3397

We now support kotlinlib built in to Mill, so we should support Kotlin modules via IntelliJ BSP as well. AFAIK the Kotlin community is mostly on IntelliJ, so we don't need to worry about VSCode for now. And since kotlinlib is now bundled with Mill, we don't need to worry about making the BSP server extendable (#2598), and can just hard-code support for KotlinModule for now

I'm not sure what exactly will need to be done to make Mill/BSP/IntelliJ/Kotlin work. It seems we have MillJavaBuildServer.scala and MillScalaBuildServer.scala, so likely we will need a corresponding MillKotlinBuildServer.scala file. We may also need changes on the IntelliJ side to allow the IntelliJ BSP client to generate Kotlin modules, if it doesn't already support that

@lihaoyi
Copy link
Member Author

lihaoyi commented Sep 26, 2024

@alexarchambault could you look into this when you're done with the current tickets you're working on?

@alexarchambault
Copy link
Contributor

alexarchambault commented Sep 26, 2024

Sure, I was actually in the midst of adding basic BSP integration tests (that would have caught BSP issues in the current state of #3599, and are needed for future BSP developments, I think)

@lihaoyi
Copy link
Member Author

lihaoyi commented Nov 13, 2024

I think we can close this, because it seems to work now. Thanks @alexarchambault !

@lihaoyi lihaoyi closed this as completed Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants