Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customising the framework in JS crashes and reports success (!) #171

Open
japgolly opened this issue Jul 12, 2018 · 0 comments
Open

Customising the framework in JS crashes and reports success (!) #171

japgolly opened this issue Jul 12, 2018 · 0 comments

Comments

@japgolly
Copy link
Collaborator

Using a customised instance of runner.Framework crashes and reports success when an assertion fails in JS.

Example with default framework:

-------------------------------- Running Tests --------------------------------
[object Object]
[object Object]
false
X japgolly.scalajs.react.core.internal.JsReprTest.implicits.caseClass 3ms 
  utest.AssertionError: assert(actual == expect)
  actual: scala.scalajs.js.Any = [object Object]
  expect: scala.scalajs.js.Any = [object Object]
    japgolly.scalajs.react.core.internal.JsReprTest$.test$1(test-test-fastopt.js:43417)
    <jscode>.{anonymous}()(test-test-fastopt.js:43330)
[info] Tests: 1, Passed: 0, Failed: 1
[error] Failed tests:
[error] 	japgolly.scalajs.react.core.internal.JsReprTest
[error] (test/test:testOnly) sbt.TestsFailedException: Tests unsuccessful
[error] Total time: 25 s, completed 12/07/2018 11:56:57 AM

Example with custom framework:

-------------------------------- Running Tests --------------------------------
[object Object]
[object Object]
false
[trace] Stack trace suppressed: run last test/test:testOnly(name: japgolly.scalajs.react.core.internal.JsReprTest, isModule: true) for the full output.
[success] Total time: 20 s, completed 12/07/2018 12:01:35 PM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant