Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach monero reserve proof to quote #1743

Open
binarybaron opened this issue Aug 1, 2024 · 0 comments · May be fixed by #1749
Open

Attach monero reserve proof to quote #1743

binarybaron opened this issue Aug 1, 2024 · 0 comments · May be fixed by #1749
Assignees
Labels
enhancement New feature or request

Comments

@binarybaron
Copy link
Collaborator

binarybaron commented Aug 1, 2024

We can allow Alice to include a Monero reserve proof in her quote which she sends to Bob. This way Bob can verify if Alice does possess the funds she offers for sale before initiating a swap with her.

This will provide some mitigation against potential spammers. Bob will check the validity of the reserve proof using check_reserve_proof before initiating the swap setup. Alice cannot offer to sell more Monero than she can prove she owns.

As long as his Monero daemon is fully synced, Bob can check the validity of a reserve proof even if his restore_height is higher than the height of the outputs Alice is proving to own. Checking if a key image is unspent is the responsibility of the daemon, not the wallet.

The only drawback is that this forces makers to expose some of the addresses of their Monero wallet. I think this is acceptable. We can make it optional for Alice to transmit a reserve proof. Bob can decide if he wants to accept offers without a reserve proof.

A detailed description of reserve proofs can be found in Zero to Monero on page 82.

@binarybaron binarybaron added the enhancement New feature or request label Aug 1, 2024
@binarybaron binarybaron self-assigned this Aug 1, 2024
@binarybaron binarybaron linked a pull request Aug 7, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant