Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename crate to use - instead of _ #3

Open
thomaseizinger opened this issue Feb 23, 2022 · 2 comments
Open

Rename crate to use - instead of _ #3

thomaseizinger opened this issue Feb 23, 2022 · 2 comments

Comments

@thomaseizinger
Copy link
Contributor

The repository is also named this way, we should align these names.

@klochowicz
Copy link
Collaborator

shouldn't we do it the other way around? hyphens are not valid Rust identifiers, and this is converted to underscores internally

@thomaseizinger
Copy link
Contributor Author

We could but we are using hyphens everywhere else already.

It is completely opinion based but I find hyphens more asthetically pleasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants