Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gauge fails to build with ghc-9.10.1: various benchmarks affected #7609

Open
1 of 22 tasks
juhp opened this issue Dec 11, 2024 · 3 comments
Open
1 of 22 tasks

gauge fails to build with ghc-9.10.1: various benchmarks affected #7609

juhp opened this issue Dec 11, 2024 · 3 comments
Labels

Comments

@juhp
Copy link
Contributor

juhp commented Dec 11, 2024

gauge (Vincent Hanquez) (not present) depended on by:

@juhp
Copy link
Contributor Author

juhp commented Dec 11, 2024

For reference the build error is:

       /home/curators/work/unpack-dir/unpacked/gauge-0.2.5-fce2cf4d6fddea9e414548e9573d952c37459bcaa4253f79b036dc31512c200f/math-fun
ctions/Numeric/Sum.hs:138:19: error: [GHC-87543]
           Ambiguous occurrence ‘foldl'’.
           It could refer to
              either ‘Prelude.foldl'’,
                     imported from ‘Prelude’ at math-functions/Numeric/Sum.hs:25:8-18
                     (and originally defined in ‘ghc-internal-9.1001.0:GHC.Internal.Data.Foldable’),
                  or ‘Data.Vector.Generic.foldl'’,
                     imported from ‘Data.Vector.Generic’ at math-functions/Numeric/Sum.hs:35:41-46.
           |
       138 | sumVector f = f . foldl' add zero
           |                   ^^^^^^

Upstream suggests switching to criterion

@ChrisPenner
Copy link
Contributor

ChrisPenner commented Dec 11, 2024

I've gone ahead and just removed benchmarks (and gauge from lens-regex-pcre at 1.1.2.0 to maintain compatibility; I can rewrite them using criterion if I end up doing active development on that package again.

@juhp juhp added the ghc-9.10 label Dec 12, 2024
@TeofilC
Copy link
Contributor

TeofilC commented Dec 12, 2024

For most cases, it looks like you can just switch to tasty-bench by switching imports. See, eg, viercc/trie-simple#16

https://hackage.haskell.org/package/tasty-bench-0.4#how-to-switch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants