Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use github token by default #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nikaro
Copy link

@nikaro nikaro commented Sep 22, 2024

Set ${{ github.token }} as the default value for github_token input.
This is the common practice, examples:

Set `${{ github.token }}` as the default value for `github_token` input.
This is the common practice, examples:

* https://github.com/actions/checkout/blob/main/action.yml#L24
* astral-sh/setup-uv#61
@woile
Copy link
Member

woile commented Sep 22, 2024

Hi, if you use the github token, other actions are not triggered. Do you know if this has been solved?

See the warning:
https://commitizen-tools.github.io/commitizen/tutorials/github_actions/#automatic-bumping-of-version

@nikaro
Copy link
Author

nikaro commented Sep 22, 2024

Hi, if you use the github token, other actions are not triggered. Do you know if this has been solved?

See the warning: https://commitizen-tools.github.io/commitizen/tutorials/github_actions/#automatic-bumping-of-version

Yes i know, this is intended to work this way so i do not think it will be "solved".

But at least it allows to push the tags without having to explicitly pass the default token (making it a little less verbose), which is enough if we do not want to trigger a workflow on tag, at least my use cases do not need it. And for those who need it, it is documented in your link (i did not touched this part of the README).

@nikaro nikaro changed the title ci: use github token by default feat: use github token by default Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants