Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy improvement #1054

Merged
merged 5 commits into from
Nov 10, 2024
Merged

mypy improvement #1054

merged 5 commits into from
Nov 10, 2024

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Apr 5, 2024

Description

This is part of #1053, which intends to catch errors earlier through a more strict mypy setting.

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Steps to Test This Pull Request

Additional context

#1053

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.58%. Comparing base (120d514) to head (1c70b89).
Report is 479 commits behind head on master.

Files with missing lines Patch % Lines
commitizen/cz/customize/customize.py 84.61% 2 Missing ⚠️
commitizen/commands/check.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1054      +/-   ##
==========================================
+ Coverage   97.33%   97.58%   +0.24%     
==========================================
  Files          42       55      +13     
  Lines        2104     2605     +501     
==========================================
+ Hits         2048     2542     +494     
- Misses         56       63       +7     
Flag Coverage Δ
unittests 97.58% <88.00%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lee-W Lee-W changed the title Mypy improvement mypy improvement Aug 22, 2024
@Lee-W Lee-W marked this pull request as ready for review August 22, 2024 03:02
@Lee-W Lee-W linked an issue Aug 22, 2024 that may be closed by this pull request
17 tasks
Copy link
Member

@woile woile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Lee-W Lee-W merged commit 1806fe8 into master Nov 10, 2024
20 of 21 checks passed
@Lee-W Lee-W deleted the mypy-improvement branch November 10, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turn on mypy check_untyped_defs = true
2 participants