-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New script: Outline LXC #472
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey,
Thanks for submitting a new script.
I've left a few comments, check them out.
And next time, make sure you don't push the build and Install.fuc ;)
This reverts commit 60f1a6b.
Hi @MickLesk, thanks for your time and effort reviewing this! I have responded to your comments, and already pushed a few fixes. Let me know if further changes are needed. Before merging I can rebase (I'm not sure I can do that already without messing up the review process). |
Checkout @havardthom's suggestions, then i take a final look into it :-) |
Seperates them from the previous block of credentials
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a few comments based on the last pulls. The script can be simplified in some places and in a few places it breaks with our standards. Nothing dramatic. But it should be adjusted and then tested.
Hi @MickLesk, @havardthom,
I have tried several things to try and get the application accessible via http://localhost:3000 but somehow I just can't get it to work.
|
Added #556, let me know your thoughts. You can try an install with
Still need to update the json, will the link stay the same, when you make it into announcement? |
I've been looking at the script for 2 hours now.
$STD sudo -u postgres psql -c “CREATE ROLE $DB_USER WITH LOGIN PASSWORD ‘$DB_PASS’;”
$STD sudo -u postgres psql -c “CREATE DATABASE $DB_NAME WITH OWNER $DB_USER ENCODING ‘UTF8’ TEMPLATE template0;”
$STD sudo -u postgres psql -c “ALTER ROLE $DB_USER SET client_encoding TO ‘utf8’;”
$STD sudo -u postgres psql -c “ALTER ROLE $DB_USER SET default_transaction_isolation TO ‘read committed’;”
$STD sudo -u postgres psql -c “ALTER ROLE $DB_USER SET timezone TO ‘UTC’”
But in the end I can say:
A lot of effort went into it, but I have no idea, if I can't get it to work properly, how can a user? @community-scripts/contributor feel free to give input |
Hi @MickLesk, thanks for your (continued!) effort looking into this! Regarding your questions:
Regarding your last point: Yes, this is frustrating. I tried several things and couldn't get it to accept connection via IP:3000 :( |
I've already considered whether I should submit an issue to the developers. It's nonsense to only enable this via a URL with a forced api (discord, Google, ...). It would make sense for a local installation to be possible with a local user. Even the change to development in the .env (that it runs locally) cannot be called up in my own network. But I get correct feedback via curl. (From the same machine) |
Another idea would be (just spun) to install a nginx/Caddy or Apache2 on it and see if it forwards it correctly. |
Yes, I agree, and there is a looong issue about this, that is now locked :P outline/outline#1881 (near the end, they discuss a workaround by using dex to create single user, or put a "fake" identity provider somewhere in the database. ) |
Yes, I also saw from |
I also spent a couple of hours yesterday trying to set this up and I could not get it to work. Set it up with a proxy (not exposed) and tried adding my keycloak as the authenticator, but still stuck with an Unfortunately since this script requires so much post install setup which is advanced, I think it will cause a lot of issues and maintenance. Personally I don't think we should add this script. If Outline decides to add regular email/password login, maybe we could add it. |
Note
We are meticulous when it comes to merging code into the main branch, so please understand that we may reject pull requests that do not meet the project's standards. It's never personal. Also, game-related scripts have a lower chance of being merged.
Description
Add a community script to install Outline as discussed in #342 (comment).
Type of change
Please check the relevant option(s):
Prerequisites
The following efforts must be made for the PR to be considered. Please check when completed:
Additional Information (optional)
bash -c "$(wget -qLO - https://github.com/burgerga/ProxmoxVE/raw/add_outline/ct/outline.sh)"
/opt/outline/.env
.Related Pull Requests / Discussions
#342 (comment)
If there are other pull requests or discussions related to this change, please link them here: