-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Script: LXC IP-Tag #536
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Håvard Gjøby Thom <[email protected]>
Co-authored-by: Håvard Gjøby Thom <[email protected]>
Co-authored-by: Håvard Gjøby Thom <[email protected]>
@havardthom what do you say about a AIO Script? https://raw.githubusercontent.com/MickLesk/Proxmox_DEV/refs/heads/main/misc/add-lxc-iptag.sh When you say yes, then i push it into this PR and remove the other files |
How does code highlighting work in editor, is the |
https://github.com/MickLesk/Proxmox_DEV/blob/main/misc/add-lxc-iptag.sh |
Guess it is ok since this is code that will not be changed very often. i would change the indentation to 2 spaces though |
I'll continue tomorrow, was still stuck on a bug and didn't manage to test it completely today |
@MickLesk Not sure if here is the right place. I suggest to make the CIDR configurable during setup. The current config wouldn't make sense in most cases. And to be honest leads to many tags on for instance the docker lxc. |
Ive 1 Tag at my docker LXC with 10 Apps 😅 |
Description
Add a new script for an Service "LXC IP-Tag".
This script originally comes from @gitsang and has been requested here several times. I also find it quite nice 😄 I also use it in my main Proxmox.
Discussion: #395
Issue: #537
Quote: "I have no concerns and glad that the community is interested in integrating this script." (@gitsang) - Thx!
The script is modified and should conform to our conventions.
The original source is located here: https://github.com/gitsang/lxc-iptag
Type of change
Please check the relevant option(s):
Prerequisites
The following efforts must be made for the PR to be considered. Please check when completed:
Additional Information (optional)
Provide any additional context or screenshots about the feature or fix here.
Before I executed the script (note runtime)
Script executed:
IP generated as Tag:
Switch IP address:
Updated Tag after IP change