Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ProtocolScreen #927

Open
wwqrd opened this issue Jun 10, 2019 · 0 comments
Open

Refactor ProtocolScreen #927

wwqrd opened this issue Jun 10, 2019 · 0 comments
Labels
refactor
Milestone
Beta-stretch

Comments

@wwqrd
Copy link
Contributor

wwqrd commented Jun 10, 2019 •
edited
Loading

Can we improve the onClickNext(), onClickPrevious() methods?

Suggestions:

  • Generalise the skipToIndex logic so that it can be used by both methods
  • Can we make the distinction clearer between? interfaceRefInstance.clickPrevious(), promptBackward(), and this.props.changeStage(`${this.props.pathPrefix}/${skipToIndex}`);
  • Can we update the logic to remove the nested if/else?
  • Can we remove interfaceRefInstance? If not, can we make the distinction clearer between clickPrevious and promptBackward?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Milestone
Beta-stretch
Development

No branches or pull requests
2 participants
@wwqrd @rebeccamadsen