Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large protocols may cause the app to crash during import on iOS. #939

Closed
wwqrd opened this issue Jun 25, 2019 · 5 comments
Closed

Large protocols may cause the app to crash during import on iOS. #939

wwqrd opened this issue Jun 25, 2019 · 5 comments

Comments

@wwqrd
Copy link
Contributor

wwqrd commented Jun 25, 2019

Attempt to implement unzipping within a stream.

Another approach might be to use a web worker if it's actually hanging and not crashing.

Related: Move to zip.js from JSZip? Or implement JSZip within webworker?

@wwqrd
Copy link
Contributor Author

wwqrd commented Jun 25, 2019

Some info from the related issue:

We are emulating FileWriter streams on Cordova, which I think is a compromise based on what we could achieve with the API. The solution might be to find a Cordova zip plugin and handle it that way, it means forking the code, but we already had to do that for emulation.

@rebeccamadsen rebeccamadsen added this to the Beta-stretch milestone Jul 1, 2019
@wwqrd
Copy link
Contributor Author

wwqrd commented Sep 30, 2019

@jthrilly
Copy link
Member

https://github.com/MobileChromeApps/cordova-plugin-zip

Looks to be abandoned, and with some issues, but perhaps worth looking for a maintained fork.

@wwqrd
Copy link
Contributor Author

wwqrd commented Sep 30, 2019

Looks like it may have been taken over by ionic enterprise? https://ionicframework.com/docs/native/zip

@jthrilly
Copy link
Member

jthrilly commented Oct 1, 2019

Looks like it may have been taken over by ionic enterprise? https://ionicframework.com/docs/native/zip

I think that's just a plugin directory - it points back to the same GitHub repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants