Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "Array Word8" in the Event module with "Path" #2

Merged
merged 6 commits into from
Nov 29, 2024

Conversation

adithyaov
Copy link
Member

No description provided.

@adithyaov adithyaov force-pushed the update-arr-to-path branch 6 times, most recently from fb03126 to 5f663c9 Compare October 27, 2024 07:23
@adithyaov
Copy link
Member Author

Failure on windows when FilePath is replaced with Path:

Failures:
  test\Streamly\Test\FileSystem\Event\Common.hs:206:9: 
  1) FS.Event.Windows.non-recursive, Root type DirType, dir created (dir)
       uncaught exception: ErrorCall
       C:\tmp\fsevent_dir-0a83ed4ef30a9141\watch-root: Time out occurred before event watcher could terminate
       CallStack (from HasCallStack):
         error, called at test\Streamly\Test\FileSystem\Event\Common.hs:206:9 in main:Streamly.Test.FileSystem.Event.Common
  To rerun use: --match "/FS.Event.Windows/non-recursive/Root type DirType/dir created (dir)/" --seed 309079538
  test\Streamly\Test\FileSystem\Event\Common.hs:206:9: 
  2) FS.Event.Windows.non-recursive, Root type DirType, dir deleted (dir)
       uncaught exception: ErrorCall
       C:\tmp\fsevent_dir-f584de686b41335e\watch-root: Time out occurred before event watcher could terminate
       CallStack (from HasCallStack):
         error, called at test\Streamly\Test\FileSystem\Event\Common.hs:206:9 in main:Streamly.Test.FileSystem.Event.Common
  To rerun use: --match "/FS.Event.Windows/non-recursive/Root type DirType/dir deleted (dir)/" --seed 309079538
  test\Streamly\Test\FileSystem\Event\Common.hs:206:9: 
  3) FS.Event.Windows.non-recursive, Root type DirType, dir moved (dir1 dir2)
       uncaught exception: ErrorCall
       C:\tmp\fsevent_dir-6af8a694c6e06503\watch-root: Time out occurred before event watcher could terminate
       CallStack (from HasCallStack):
         error, called at test\Streamly\Test\FileSystem\Event\Common.hs:206:9 in main:Streamly.Test.FileSystem.Event.Common
  To rerun use: --match "/FS.Event.Windows/non-recursive/Root type DirType/dir moved (dir1 dir2)/" --seed 309079538
  test\Streamly\Test\FileSystem\Event\Common.hs:206:9: 
  4) FS.Event.Windows.non-recursive, Root type DirType, File created (file1)
       uncaught exception: ErrorCall
       C:\tmp\fsevent_dir-a37c23dd8f2a3934\watch-root: Time out occurred before event watcher could terminate
       CallStack (from HasCallStack):
         error, called at test\Streamly\Test\FileSystem\Event\Common.hs:206:9 in main:Streamly.Test.FileSystem.Event.Common
  To rerun use: --match "/FS.Event.Windows/non-recursive/Root type DirType/File created (file1)/" --seed 309079538
  test\Streamly\Test\FileSystem\Event\Common.hs:206:9: 
  5) FS.Event.Windows.non-recursive, Root type DirType, File deleted (file1)
       uncaught exception: ErrorCall
       C:\tmp\fsevent_dir-4c81fcd7b5878b74\watch-root: Time out occurred before event watcher could terminate
       CallStack (from HasCallStack):
         error, called at test\Streamly\Test\FileSystem\Event\Common.hs:206:9 in main:Streamly.Test.FileSystem.Event.Common
  To rerun use: --match "/FS.Event.Windows/non-recursive/Root type DirType/File deleted (file1)/" --seed 309079538
  test\Streamly\Test\FileSystem\Event\Common.hs:206:9: 
  6) FS.Event.Windows.non-recursive, Root type DirType, File modified (file1)
       uncaught exception: ErrorCall
       C:\tmp\fsevent_dir-9398c94495ed63a9\watch-root: Time out occurred before event watcher could terminate
       CallStack (from HasCallStack):
         error, called at test\Streamly\Test\FileSystem\Event\Common.hs:206:9 in main:Streamly.Test.FileSystem.Event.Common
  To rerun use: --match "/FS.Event.Windows/non-recursive/Root type DirType/File modified (file1)/" --seed 309079538
  test\Streamly\Test\FileSystem\Event\Common.hs:206:9: 
  7) FS.Event.Windows.non-recursive, Root type DirType, File moved (file1 file2)
       uncaught exception: ErrorCall
       C:\tmp\fsevent_dir-2bd813fb915441a1\watch-root: Time out occurred before event watcher could terminate
       CallStack (from HasCallStack):
         error, called at test\Streamly\Test\FileSystem\Event\Common.hs:206:9 in main:Streamly.Test.FileSystem.Event.Common

src/Streamly/Internal/FS/Event/Linux.hs Outdated Show resolved Hide resolved
src/Streamly/Internal/FS/Event/Linux.hs Outdated Show resolved Hide resolved
src/Streamly/Internal/FS/Event/Linux.hs Show resolved Hide resolved
src/Streamly/Internal/FS/Event/Linux.hs Show resolved Hide resolved
src/Streamly/Internal/FS/Event/Windows.hs Outdated Show resolved Hide resolved
src/Streamly/Internal/FS/Event/Windows.hs Show resolved Hide resolved
src/Streamly/Internal/FS/Event/Windows.hs Outdated Show resolved Hide resolved
src/Streamly/Internal/FS/Event/Windows.hs Outdated Show resolved Hide resolved
@adithyaov adithyaov force-pushed the update-arr-to-path branch 2 times, most recently from 838cc72 to ee0d8e0 Compare November 12, 2024 10:15
@adithyaov adithyaov force-pushed the update-arr-to-path branch 2 times, most recently from ac22777 to b8211e9 Compare November 28, 2024 14:48
Copy link
Member

@harendra-kumar harendra-kumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create an issue to remove all uses of Path.toString, except where it is used for printing.

@adithyaov
Copy link
Member Author

Also see: #4

@adithyaov adithyaov merged commit 87f1c50 into master Nov 29, 2024
7 checks passed
@adithyaov adithyaov mentioned this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In the FileSystem.Event module replace "Array Word8" with Path
2 participants