Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type definitions for exported object and constants #10

Closed
wants to merge 3 commits into from
Closed

Add type definitions for exported object and constants #10

wants to merge 3 commits into from

Conversation

0xbhagwan
Copy link

fixes #9

Was not able to run tests due to error

Details:

    /home/humanbeing/Documents/Repos/compound-js/test/eth.test.js:4
    import * as eth from '../src/eth';
    ^^^^^^

    SyntaxError: Cannot use import statement outside a module

      at compileFunction (node:vm:356:18)
      at processTicksAndRejections (node:internal/process/task_queues:93:5)

@0xbhagwan
Copy link
Author

After checking, my changes make the Compound constructor not callable, looking into alternatives

@0xbhagwan 0xbhagwan mentioned this pull request Dec 8, 2020
Open
@0xbhagwan 0xbhagwan changed the title Change object assign to spread operator to preserve type safety Add type definitions for exported object and constants Dec 8, 2020
@ajb413
Copy link
Collaborator

ajb413 commented Jan 12, 2021

Hi @0xbhagwan. Have you found a solution to the issue? If so, please write a test that confirms that the SDK still works. I have added test coverage since you began working on this branch.

@ajb413 ajb413 closed this Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cToken constants missing from Compound typescript definitions
2 participants
@0xbhagwan @ajb413