Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Show course conflicts #5

Open
jsun969 opened this issue Sep 23, 2024 · 3 comments
Open

[Feature Request] Show course conflicts #5

jsun969 opened this issue Sep 23, 2024 · 3 comments
Labels
enhancement New feature or request priority:high

Comments

@jsun969
Copy link
Member

jsun969 commented Sep 23, 2024

Overview

Show conflicts between courses in both chips and calendar.

Details

For chip and course modal: add a ⚠️ emoji in chip and show conflict details in course modal

For calendar: conflict course cards should be displayed side by side like
CleanShot 2024-09-23 at 12 35 21@2x

There is a timeOverlap util function (utils/time-overlap-ts) which may be helpful.

Remove course sorting in getWeekCourses (helpers/calendar.ts) and zIndex in CalendarCourses (components/Calendar.tsx) since it's for displaying conflicts by opacity.

Why would this feature be useful?

Tell user which courses are conflict when scheduling timetable

Additional Notes

No response

@jsun969
Copy link
Member Author

jsun969 commented Sep 25, 2024

Fixed the conflicts in calendar when times are same. But overlapping time is still an issue

CleanShot 2024-09-25 at 15 45 28@2x

@cyruskelly
Copy link

If there is a conflict between a course and an immovable course the immovable course will not display correctly:
image
image

@jsun969
Copy link
Member Author

jsun969 commented Oct 14, 2024

@cyruskelly

I think it's correctly displayed for now. Since courses with longer duration will be at bottom to make sure user can drag courses that have shorter duration, they will be covered.

But it will be better if we can solve this issue and display conflicts like apple calendar.

@jsun969 jsun969 pinned this issue Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:high
Projects
None yet
Development

No branches or pull requests

2 participants