Passing ListHeaderComponent and/or ListFooterComponent throws errors on drag #483
Comments
NoahCardoza
pushed a commit
to NoahCardoza/react-native-draggable-flatlist
that referenced
this issue
Jun 21, 2023
…ent from PropsProvider
NoahCardoza
pushed a commit
to NoahCardoza/react-native-draggable-flatlist
that referenced
this issue
Jun 21, 2023
…ent from PropsProvider
|
Hitting the same issue. If I remove the ListHeaderComponent then the issue goes away. (But I need to use the header component...) Edit: Confirming that PR #484 fixes the issue for us. react-native-draggable-flatlist: 4.0.1 |
|
Also works react-native-draggable-flatlist: 4.0.1 Patchdiff --git a/node_modules/react-native-draggable-flatlist/src/components/DraggableFlatList.tsx b/node_modules/react-native-draggable-flatlist/src/components/DraggableFlatList.tsx
index d7d98c2..183d431 100644
--- a/node_modules/react-native-draggable-flatlist/src/components/DraggableFlatList.tsx
+++ b/node_modules/react-native-draggable-flatlist/src/components/DraggableFlatList.tsx
@@ -402,14 +402,22 @@ function DraggableFlatListInner<T>(props: DraggableFlatListProps<T>) {
}
function DraggableFlatList<T>(
- props: DraggableFlatListProps<T>,
+ {
+ ListFooterComponent,
+ ListHeaderComponent,
+ ...props
+ }: DraggableFlatListProps<T>,
ref?: React.ForwardedRef<FlatList<T>> | null
) {
return (
<PropsProvider {...props}>
<AnimatedValueProvider>
<RefProvider flatListRef={ref}>
- <MemoizedInner {...props} />
+ <MemoizedInner
+ {...props}
+ ListFooterComponent={ListFooterComponent}
+ ListHeaderComponent={ListHeaderComponent}
+ />
</RefProvider>
</AnimatedValueProvider>
</PropsProvider> |
|
Not able to pass components directly, which causes re-rendering issues.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Passing
ListHeaderComponentand/orListFooterComponentcause somewhere insidereact-native-draggable-flatlistto raiseTypeError: Attempted to assign to readonly property (node._store), which seems to be related to this.To Reproduce
I don't have one at the moment. We aren't using expo, and I couldn't get Expo Snack to install the reanimated library.
Platform & Dependencies
The text was updated successfully, but these errors were encountered: