-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add geogram #25231
base: master
Are you sure you want to change the base?
Feature/add geogram #25231
Conversation
9350c2c
to
53c861a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks a lot :) Some comments
if self.options.with_graphics: | ||
self.cpp_info.components["geogram_gfx"].includedirs = ["include/geogram1"] | ||
self.cpp_info.components["geogram_gfx"].libs = ["geogram_gfx"] | ||
self.cpp_info.components["geogram_gfx"].requires = ["geogram", "glfw::glfw"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No imgui etc?
def generate(self): | ||
tc = CMakeToolchain(self) | ||
tc.variables["VORPALINE_BUILD_DYNAMIC"] = self.options.shared | ||
tc.variables["GEOGRAM_WITH_GRAPHICS"] = self.options.with_graphics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide compilation logs for with_graphics = True
? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me locally, this is failing with
-- Conan: Target declared 'boost::boost'-- Conan: Target declared 'ZLIB::ZLIB'-- Conan: Target declared 'BZip2::BZip2'-- Conan: Including build module from '/root/.conan2/p/b/bzip218486de5f52aa/p/lib/cmake/conan-official-bzip2-variables.cmake'-- Conan: Target declared 'libbacktrace::libbacktrace'-- Configuring doneCMake Error at src/lib/geogram_gfx/third_party/CMakeLists.txt:35 (add_library):
Cannot find source file:
imgui/imgui.cpp
Tried extensions .c .C .c++ .cc .cpp .cxx .cu .mpp .m .M .mm .ixx .cppm .h
.hh .h++ .hm .hpp .hxx .in .txx .f .F .for .f77 .f90 .f95 .f03 .hip .ispc
Seems like it's trying to use a vendorized imgui?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AbrilRBS,
sorry for the late answer.
I come back on this recipe and just discover that with with_graphics option enabled, geogram depends of some imgui backens (https://github.com/BrunoLevy/geogram/blob/main/src/lib/geogram_gfx/third_party/CMakeLists.txt#L48 and https://github.com/BrunoLevy/geogram/blob/main/src/lib/geogram_gfx/third_party/CMakeLists.txt#L67).
Thanks to @valgur, who contributed a recipe evolution to imgui, see #25325, this is possible.
Consequently @AbrilRBS could you make a review of @valgur PR?
Thanks in advance.
This comment has been minimized.
This comment has been minimized.
53c861a
to
bcd54e9
Compare
This comment has been minimized.
This comment has been minimized.
bcd54e9
to
0a63259
Compare
This comment has been minimized.
This comment has been minimized.
0a63259
to
9790212
Compare
This comment has been minimized.
This comment has been minimized.
9790212
to
9018e36
Compare
This comment has been minimized.
This comment has been minimized.
9018e36
to
0ff479b
Compare
This comment has been minimized.
This comment has been minimized.
0ff479b
to
544aa18
Compare
This comment has been minimized.
This comment has been minimized.
544aa18
to
e77bd17
Compare
This comment has been minimized.
This comment has been minimized.
e77bd17
to
242e15f
Compare
This comment has been minimized.
This comment has been minimized.
242e15f
to
446015c
Compare
This comment has been minimized.
This comment has been minimized.
446015c
to
474c8b8
Compare
This comment has been minimized.
This comment has been minimized.
474c8b8
to
396d7f4
Compare
This comment has been minimized.
This comment has been minimized.
396d7f4
to
c4adf95
Compare
This comment has been minimized.
This comment has been minimized.
c4adf95
to
83d4521
Compare
This comment has been minimized.
This comment has been minimized.
83d4521
to
2dea3d4
Compare
This comment has been minimized.
This comment has been minimized.
2dea3d4
to
7a83db5
Compare
Conan v1 pipeline ❌Warning Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement. Failure in build 19 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping Failure in build 19 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Summary
Add recipe: geogram/1.9.0