Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "opencolorio: Bump lcms requirement to 2.16" #25794

Merged
merged 2 commits into from
Nov 2, 2024

Conversation

AbrilRBS
Copy link
Member

@AbrilRBS AbrilRBS commented Nov 2, 2024

Reverts #25660

This was not meant to be merged until #25672 is ready, as it creates a conflict with its whole tree

@AbrilRBS AbrilRBS self-assigned this Nov 2, 2024
ErniGH
ErniGH previously approved these changes Nov 2, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

All green in build 2 (b3901e242e8473f5b3ae24b1d30b55dcbc8a5260):

  • opencolorio/2.4.0:
    Built 14 packages out of 22 (All logs)

  • opencolorio/2.3.0:
    Built 14 packages out of 22 (All logs)

  • opencolorio/2.3.1:
    Built 14 packages out of 22 (All logs)

  • opencolorio/2.2.1:
    Built 18 packages out of 22 (All logs)

  • opencolorio/1.1.1:
    All packages built successfully! (All logs)

  • opencolorio/2.1.0:
    All packages built successfully! (All logs)

  • opencolorio/2.3.2:
    Built 14 packages out of 22 (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 2 (b3901e242e8473f5b3ae24b1d30b55dcbc8a5260):

  • opencolorio/1.1.1:
    Built 3 packages out of 10 (All logs)

  • opencolorio/2.3.0:
    Built 3 packages out of 10 (All logs)

  • opencolorio/2.3.2:
    Built 3 packages out of 10 (All logs)

  • opencolorio/2.4.0:
    Built 3 packages out of 10 (All logs)

  • opencolorio/2.3.1:
    Built 3 packages out of 10 (All logs)

  • opencolorio/2.1.0:
    All packages built successfully! (All logs)

  • opencolorio/2.2.1:
    Built 3 packages out of 10 (All logs)

@irieger
Copy link
Contributor

irieger commented Nov 2, 2024

Hey, if we merge #25790 it would rebuild all openimageio packages currently existing so they should match the opencolorio with lcms/2.16. Just merged master in to trigger a rebuild of #25790. This should show which packages are fetched. Would that solve the problem so that the revert is unnecessary or is there another reason to revert?

@AbrilRBS
Copy link
Member Author

AbrilRBS commented Nov 2, 2024

@irieger the Conan 1 freeze is happening next week, and I didn't want to leave this new conflict hanging there forever just because the bot merged it unexpectedly :(

@jcar87 jcar87 merged commit 0e053a6 into master Nov 2, 2024
33 checks passed
@jcar87 jcar87 deleted the revert-25660-opencolorio/bump-lcms branch November 2, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants