-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dask-image v2023.8.1 #14
dask-image v2023.8.1 #14
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Marvin! 🙏
Had a couple questions below
For reference the discussion regarding the CI test failures here is occurring upstream: dask/dask-image#330 (comment) |
The new Arrow-based strings that Dask uses appear to cause dask-image test failures. So just disable them for now. Also link to an upstream tracking issue for reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for fixing this @jakirkham ! Added some comments.
Ensure consistency with v2023.08.0 on pypi and therefore also support python 3.8 here. Co-authored-by: jakirkham <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks pretty good, and I approve the plan for a patch v2023.8.1 to get rid of the last references to python 3.8. Sorry we didn't catch them all earlier!
Definitely don't worry at all about whether the release history looks slightly messy, nobody will care about that.
I agree it's a good idea to yank v2023.8.0 from pypi in favour of 2023.8.1. But again, it seems very unlikely that anybody is going to actually end up installing it with python 3.8 and have problems, so don't worry too much about it.
Thanks for the change of PR title @jakirkham, that clarifies things :) All seems good, merging now! Thanks @jakirkham and @GenevieveBuckley 🙏 EDIT: Accidentally clicked on "close with comment" on this one 🙈 Not a problem though 😅. |
Thanks Marvin! 🥳 If you have a moment to write your thoughts on how this release went and what we could improve, that would be really helpful |
Hi! This is the friendly automated conda-forge-webservice.
I've started a version update as instructed in #13.
I'm currently searching for new versions and will update this PR shortly if I find one! Thank you for waiting!
Fixes #13
Closes #15