Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove COPYING File from Library to avoid clobber warning. #143

Merged
merged 4 commits into from
Dec 2, 2020

Conversation

hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk commented Dec 2, 2020

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Dec 2, 2020

@conda-forge-admin please rerender

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2020

Hi! This is the friendly automated conda-forge-webservice.
I tried to rerender for you, but it looks like there was nothing to do.

@hmaarrfk hmaarrfk mentioned this pull request Dec 2, 2020
@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Dec 2, 2020

I would appreciate this being merged even if OSX/Linux fail since this is a windows only fix.

I expect linux to fail due to conda-forge/docker-images#165

@beckermr beckermr added the automerge Merge the PR when CI passes label Dec 2, 2020
@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Dec 2, 2020

@beckermr i'm going to go ahead and remove a few other generic sounding files.

-- Installing: D:/bld/hdf5_split_1606931441906/_h_env/Library/./COPYING
-- Installing: D:/bld/hdf5_split_1606931441906/_h_env/Library/./USING_HDF5_CMake.txt
-- Up-to-date: D:/bld/hdf5_split_1606931441906/_h_env/Library/./COPYING
-- Installing: D:/bld/hdf5_split_1606931441906/_h_env/Library/./RELEASE.txt
-- Installing: D:/bld/hdf5_split_1606931441906/_h_env/Library/./USING_HDF5_VS.txt

@scopatz
Copy link
Member

scopatz commented Dec 2, 2020

Maybe it would be better to patch out that part of the CMake file rather than removing it after install?

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Dec 2, 2020

crossplatform patching is really annoying....

can you maybe also comment on: #87 (comment)

@beckermr
Copy link
Member

beckermr commented Dec 2, 2020

Installing and then removing is more robust than patching the build. It won't ever go out of date as the build changes. The worst-case scenario is that we miss a file to remove and have to come back and fix it later. Updating patches is an awful job.

LGTM!

@github-actions github-actions bot merged commit ebddc4c into conda-forge:master Dec 2, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2020

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • drone: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@beckermr
Copy link
Member

beckermr commented Dec 2, 2020

Woops. That was the bot that merged since we forgot to remove the automerge label. We can back this out if others have more comments.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Dec 2, 2020

Yeah, lets discuss in: #87 (comment)

I think i found a good variable to update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the PR when CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants