-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove COPYING File from Library to avoid clobber warning. #143
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin please rerender |
Hi! This is the friendly automated conda-forge-webservice. |
I would appreciate this being merged even if OSX/Linux fail since this is a windows only fix. I expect linux to fail due to conda-forge/docker-images#165 |
@beckermr i'm going to go ahead and remove a few other generic sounding files.
|
Maybe it would be better to patch out that part of the CMake file rather than removing it after install? |
crossplatform patching is really annoying.... can you maybe also comment on: #87 (comment) |
Installing and then removing is more robust than patching the build. It won't ever go out of date as the build changes. The worst-case scenario is that we miss a file to remove and have to come back and fix it later. Updating patches is an awful job. LGTM! |
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
Woops. That was the bot that merged since we forgot to remove the automerge label. We can back this out if others have more comments. |
Yeah, lets discuss in: #87 (comment) I think i found a good variable to update. |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)