Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding recipe for knem-headers #28070

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Adding recipe for knem-headers #28070

wants to merge 5 commits into from

Conversation

j34ni
Copy link
Contributor

@j34ni j34ni commented Oct 31, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/knem-headers/meta.yaml) and found some lint.

Here's what I've got...

For recipes/knem-headers/meta.yaml:

  • There are 3 too many lines. There should be one empty line at the end of the file.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/knem-headers/meta.yaml) and found it was in an excellent condition.

@j34ni
Copy link
Contributor Author

j34ni commented Oct 31, 2024

The knem project comprises multiple components, including a user-space library and a crucial kernel module that facilitates efficient memory copy operations at the kernel level. This package specifically provides the knem_io.h header from the knem project, allowing other software, like UCX, to interface with the knem kernel module, enabling high-performance communication in distributed computing environments.

recipes/knem-headers/meta.yaml Outdated Show resolved Hide resolved
skip: true # [win or osx]

run_exports:
- {{ pin_subpackage('knem-headers', max_pin='x.y.z') }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these are only headers, there should be no runtime dependency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

recipes/knem-headers/meta.yaml Outdated Show resolved Hide resolved
@j34ni
Copy link
Contributor Author

j34ni commented Nov 23, 2024

@xhochy Is that OK now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants