Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add rnr, rune, rustywind, rusync, sad #28324

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add rnr, rune, rustywind, rusync, sad #28324

wants to merge 4 commits into from
+341 −0

Conversation

danielnachun
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 23, 2024 •
edited
Loading

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/sad/meta.yaml, recipes/rusync/meta.yaml, recipes/rune/meta.yaml, recipes/rnr/meta.yaml, recipes/rustywind/meta.yaml) and found it was in an excellent condition.

@github-actions GitHub Actions
Copy link

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@danielnachun
Copy link
Contributor Author

@conda-forge/staged-recipes @conda-forge/help-rust This is now ready for review.

@github-actions GitHub Actions
Copy link

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

xhochy
xhochy requested changes Nov 23, 2024
View reviewed changes
Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of calling strip can you please add the following environment variables to all build scripts?

export CARGO_PROFILE_RELEASE_STRIP=symbols
export CARGO_PROFILE_RELEASE_LTO=fat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhochy xhochy xhochy requested changes

Assignees
No one assigned
Labels
R review-requested rust staged-recipes
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielnachun @conda-forge-admin @xhochy