Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSIS has a 2GB installer size limit #650

Open
2 tasks done
jaimergp opened this issue Feb 22, 2023 · 2 comments
Open
2 tasks done

NSIS has a 2GB installer size limit #650

jaimergp opened this issue Feb 22, 2023 · 2 comments
Labels
os::windows relevant to Windows stale::recovered [bot] recovered after being marked as stale type::bug describes erroneous operation, use severity::* to classify the type

Comments

@jaimergp
Copy link
Contributor

Checklist

  • I added a descriptive title
  • I searched open reports and couldn't find a duplicate

What happened?

Comes from mne-tools/mne-installers#168 (comment). Thanks @larsoner and @hoechenberger for the research.

nsis has a 2GB limit file size. This can be hit if your project adds big things like pytorch, cudatoolkit and others.

There are nsis-derivatives like nsisbi which can increase this limit to 4GB with some trickery, and beyond that with an external file. I don't know how to feel about using nsisbi by default, but we might be able to enable this with a flag, or a new installer_type or something (large-exe?).

Conda Info

No response

Conda Config

No response

Conda list

No response

Additional Context

No response

@jaimergp jaimergp added type::bug describes erroneous operation, use severity::* to classify the type os::windows relevant to Windows labels Feb 22, 2023
Copy link

Hi there, thank you for your contribution!

This issue has been automatically marked as stale because it has not had recent activity. It will be closed automatically if no further activity occurs.

If you would like this issue to remain open please:

  1. Verify that you can still reproduce the issue at hand
  2. Comment that the issue is still reproducible and include:
    - What OS and version you reproduced the issue on
    - What steps you followed to reproduce the issue

NOTE: If this issue was closed prematurely, please leave a comment.

Thanks!

@github-actions github-actions bot added the stale [bot] marked as stale due to inactivity label Feb 23, 2024
@jaimergp
Copy link
Contributor Author

not stale

@github-actions github-actions bot added stale::recovered [bot] recovered after being marked as stale and removed stale [bot] marked as stale due to inactivity labels Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os::windows relevant to Windows stale::recovered [bot] recovered after being marked as stale type::bug describes erroneous operation, use severity::* to classify the type
Projects
Status: No status
Development

No branches or pull requests

1 participant