Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we support sdk v0.43 as well #192

Closed
ethanfrey opened this issue Jun 9, 2021 · 5 comments
Closed

Ensure we support sdk v0.43 as well #192

ethanfrey opened this issue Jun 9, 2021 · 5 comments

Comments

@ethanfrey
Copy link
Contributor

This seems to have some breaking changes (in events at least... maybe some in protobuf msg?) from 0.42, so the relayer must be smart enough to handle it.

See informalsystems/hermes#918 and informalsystems/hermes#1057

@ethanfrey
Copy link
Contributor Author

We should also favor the packet_data_hex attribute (if present) over packet_data.

This is only present in ibc-go: https://github.com/cosmos/ibc-go/blob/main/modules/core/04-channel/keeper/packet.go#L135

@ethanfrey
Copy link
Contributor Author

This should work with CosmJS 0.27.
We need to test the ibc semantics, maybe add hex_data etc.
Definitely need to update CI script

@webmaster128
Copy link
Member

Please note that the simapp 0.44 (maybe 0.43 as well) does not include IBC support anymore because the ibc module was removed from the cosmos-sdk repo. So this might require changes to the test setup.

@ethanfrey
Copy link
Contributor Author

Oh no.
I guess I can test with gaia v6.0 or something... and ensure both 0.42 and 0.44 support?
And then ibc 1.2 and ibc 2.0?
ugh

@ethanfrey
Copy link
Contributor Author

Closed by #214 as gaiad v6 is using Cosmos SDK 0.44 and ibcv2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants