Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-commit #2

Open
Dauliac opened this issue May 24, 2021 · 2 comments
Open

Pre-commit #2

Dauliac opened this issue May 24, 2021 · 2 comments

Comments

@Dauliac
Copy link
Collaborator

Dauliac commented May 24, 2021

@thomaslepoix
At my work, I tested this tool: https://github.com/pre-commit/pre-commit

it's cool and allow us to improve and define code quality rules.

Do you agree ?

It can be a good tool to use with TDD,linted, auto formatted, auto documented code.

@thomaslepoix
Copy link
Member

Good idea.

I am not for being too restrictive for commits on dev branch, maybe just forcing style?

On master branch, I think project should be at least building and unit tests passing.

I think we also should add bots like LGTM or SonarCloud to review pull requests.

@Dauliac
Copy link
Collaborator Author

Dauliac commented May 31, 2021

purpose:

  • style everywhere
  • tests/coverage/etc only on master or release branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants