Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client should enforce configured timeout #267

Closed
jhump opened this issue May 28, 2024 · 0 comments · Fixed by #265
Closed

client should enforce configured timeout #267

jhump opened this issue May 28, 2024 · 0 comments · Fixed by #265

Comments

@jhump
Copy link
Member

jhump commented May 28, 2024

In #247, the ability to set an optional timeout on the protocol config was added. But the timeout is just advisory: it is passed along to the server via a protocol-specific timeout header, but not the operation is not canceled by the client after the timeout elapses.
@jhump jhump mentioned this issue May 28, 2024
Merged
rebello95 added a commit that referenced this issue May 29, 2024
@rebello95
Add client-side timeout enforcement (#265)
734f946 
Adds support for triggering client-side timeouts if the client is
configured to do so. Resolves several previously opted-out conformance
tests.

Resolves #267.

---------

Signed-off-by: Michael Rebello <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add client-side timeout enforcement connectrpc/connect-swift
1 participant
@jhump