Mmi 5817 implement support for beefy on linea #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpsains
force-pushed
the
MMI-5817-implement-support-for-beefy-on-linea
branch
from
60017e5 to
c93b46a
Compare
bergarces
reviewed
Dec 10, 2024
packages/adapters-library/src/adapters/beefy/products/moo-token/beefyMooTokenAdapter.ts
Outdated
Show resolved
Hide resolved
bergarces
reviewed
Dec 10, 2024
bergarces
reviewed
Dec 10, 2024
| const db = new Database(`./${ChainIdToChainNameMap[chainId]}.db`, { | ||
| verbose: console.log, | ||
| }) | ||
|
|
There was a problem hiding this comment.
We could run the query to fetch the pools once and passed the value to every delete query, instead of calculating it every time.
SELECT p.pool_id
FROM adapters a
JOIN pools p ON p.adapter_id = a.adapter_id
WHERE a.protocol_id = ? AND a.product_id = ?
The way it's written was ok for a sql script, where you cannot (should not) use variables, but that restriction does not apply here.
bergarces
reviewed
Dec 10, 2024
| } | ||
| } | ||
|
|
||
| protected async unwrapProtocolToken( |
There was a problem hiding this comment.
If they are not being inherited and used by a subclass, they should be private.
bergarces
reviewed
Dec 10, 2024
packages/adapters-library/src/adapters/beefy/products/moo-token/beefyMooTokenAdapter.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Bernardo Garces Chapero <[email protected]>
…n/beefyMooTokenAdapter.ts Co-authored-by: Bernardo Garces Chapero <[email protected]>
…n/beefyMooTokenAdapter.ts Co-authored-by: Bernardo Garces Chapero <[email protected]>
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.