-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: still check request payload #229
base: master
Are you sure you want to change the base?
Conversation
the ttrpc golang do not send flagNodata in the request even it is an empty request. Signed-off-by: Abel Feng <[email protected]>
/cc @wllenyj |
We don't have a test case to verify this ok yet. Previously I was doing compatibility test in my locally. Are there any compatibility issues between the current implementation and the Golang version? |
The ttrpc-rust checks if there is no data in the request by FLAG_NO_DATA set. but golang version do not set this flag even it has no data
so even it is an empty request with no data, because golang version do not set FLAG_NO_DATA, we will send an empty message to the stream handler, which is not expected.
|
@Tim-Zhang Is there conflict this commit with the changes of #208 ? |
It seems golang version of ttrpc fix the empty payload by checking if the client stream is set. Shall rust version follow that logic? |
It seems we do not distinguish |
@abel-von It does not work because
@wllenyj It seems ttrpc-rust's handle of MESSAGE_TYPE_REQUEST is diff with ttrpc, I think the mechanism should be reviewd,. |
the ttrpc golang do not send flagNodata in the request even it is an empty request.
fix #221