Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/1.1] Backport CI updates and enable CI on release 1.1 branch #163

Merged
merged 4 commits into from
May 16, 2024

Conversation

austinvazquez
Copy link
Member

@austinvazquez austinvazquez commented Mar 1, 2024

Issue

The release/1.1 branch currently has no CI for validating changes.

Description

This change backports the following CI updates and enables CI for the branch.

Signed-off-by: Vincent Batts <[email protected]>
(cherry picked from commit 9660e6b)
Signed-off-by: Austin Vazquez <[email protected]>
@austinvazquez austinvazquez force-pushed the enable-ci-on-release branch 3 times, most recently from 6689d3f to 7eb75ab Compare March 1, 2024 20:50
Update GitHub Actions runner OS from Ubuntu 18.04 to Ubuntu 22.04.
Update actions/setup-go from v2 to v3. Update Go compiler from Go 1.17
to Go 1.20. Update golangci-lint from v1.45.0 to v1.51.2 for Go 1.20
support. Remove deprecated `-i` flag from make coverage target.

Signed-off-by: Austin Vazquez <[email protected]>
(cherry picked from commit c7b5a32)
Signed-off-by: Austin Vazquez <[email protected]>
Signed-off-by: Austin Vazquez <[email protected]>
(cherry picked from commit 589a593)
Signed-off-by: Austin Vazquez <[email protected]>
Signed-off-by: Austin Vazquez <[email protected]>
@austinvazquez
Copy link
Member Author

The unit test failure on Windows has been root caused and will be resolved by #164.

@austinvazquez austinvazquez marked this pull request as ready for review March 1, 2024 21:04
@austinvazquez
Copy link
Member Author

@estesp , @dmcgowan PTAL. This change enables CI on release/1.1 branch which is a good to have to validate #160.

@dmcgowan dmcgowan merged commit 4b1d164 into containerd:release/1.1 May 16, 2024
6 checks passed
@austinvazquez austinvazquez deleted the enable-ci-on-release branch May 16, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants