Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: tag daily builds of images #4717

Open
Blaimi opened this issue Apr 6, 2023 · 3 comments
Open

feature request: tag daily builds of images #4717

Blaimi opened this issue Apr 6, 2023 · 3 comments

Comments

@Blaimi
Copy link

Blaimi commented Apr 6, 2023

Description

You are building the buildah container images on a daily base to avoid security-problems. I think this is fine and I welcome this 👍 .

If your build has a bug like the one in #4715, it's not possible for a user to rollback to an older image until the bug is fixed to get the pipelines running.

It would be nice to have tags of the builds for at least the last one or two weeks. When you cleanup the images on a regular base, you can avoid users relying on these tags abusively.

E.g. texlive uses this strategy for their images with weekly builds (registry-link with filter-example)

Steps to reproduce the issue:

  1. me: using buildah-image
  2. you: implement a bug, e.g. Buildah version 1.29.1 broken fuse-overlayfs in gitlab runner #4715

Describe the results you received:
3. me: 🤷

Describe the results you expected:

  1. me: temporary switch to image from the day before the bug until it is fixed
  2. me: 😄
@dhduvall
Copy link

dhduvall commented Apr 6, 2023

The documentation for the image, at https://github.com/containers/buildah/tree/main/contrib/buildahimage says

quay.io/containers/buildah:<version> and quay.io/buildah/stable:<version> - These images are built daily. They are intended to contain an unchanging and stable version of buildah.

which suggests that while the underlying OS bits are expected to change on a daily basis, the buildah bits stay exactly the same (or at least built from the same source), with the release matching the image tag.

I think that's a great policy, but I don't know whether it's not being implemented because the documentation is out of date and the current behavior is intentional or inadvertent.

skopeo has the same issue; I haven't checked the other repos.

Having tags for the past N builds seems reasonable, but I would also be happy with selecting the image version with the hash—only the older manifests don't seem to exist after they've been superseded, so that's not an option, unless I copy the image to a private repo.

@elacheche
Copy link

elacheche commented Apr 7, 2023

which suggests that while the underlying OS bits are expected to change on a daily basis, the buildah bits stay exactly the same (or at least built from the same source), with the release matching the image tag.

Hello,

Is /etc/containers/storage.conf part of the OS bits? Because that's what's causing #4715 (comment).

And so, the latest tag of yesterday is not the same as the latest tag of t2 days ago..

@github-actions
Copy link

github-actions bot commented May 8, 2023

A friendly reminder that this issue had no activity for 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants