-
Notifications
You must be signed in to change notification settings - Fork 785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
race: parallel builds: copying...committing...creating... layer not known #5674
Comments
Issue persists:
Podman PR containers/podman#23275 with current buildah (v1.37.1-0.20240828183349-69259725a0df) vendored. |
This is two builds with |
Need --layers=false in podman build, otherwise a buildah race can trigger "layer not known" failures: containers/buildah#5674 Signed-off-by: Ed Santiago <[email protected]>
A friendly reminder that this issue had no activity for 30 days. |
This is not stale, but I don't have privs to edit tags in this repo. |
In preparation for maybe some day being able to run build tests in parallel. SUPER IMPORTANT NOTE! BUILD TESTS CANNOT BE PARALLELIZED YET! buildah, when run in parallel, barfs with: race: parallel builds: copying...committing...creating... layer not known See containers/buildah#5674 Signed-off-by: Ed Santiago <[email protected]>
In preparation for maybe some day being able to run build tests in parallel. SUPER IMPORTANT NOTE! BUILD TESTS CANNOT BE PARALLELIZED YET! buildah, when run in parallel, barfs with: race: parallel builds: copying...committing...creating... layer not known Until this is fixed, podman-build can never be run in parallel. See containers/buildah#5674 This PR is simply cleaning things up so, if/when that day comes, the ensuing parallelize PR will be short & sweet. Signed-off-by: Ed Santiago <[email protected]>
@edsantiago added the power, use it responsibly. 😄 |
DO NOT MERGE! Seriously, like don't even fantasize about it until containers/buildah#5674 is fixed and the fix is vendored into podman. I am filing this because if/when that happens, this PR will give you a nice CI-runtime boost. I spent a good chunk of time identifying the tests which can / can't be parallelized in this module. Hope it helps some day. Signed-off-by: Ed Santiago <[email protected]>
A friendly reminder that this issue had no activity for 30 days. |
This might be the same as containers/podman#23331 . If it is, someone please close this or move.
Setup:
$ for i in 1 2;do printf "FROM quay.io/libpod/testimage:20240123\nRUN echo hi from $i\n" >Containerfile$i;done
In window 1:
$ while :;do buildah build -t c1 --layers=true -f Containerfile1 || break;buildah rmi c1;done
In window 2:
$ while :;do buildah build --layers=false -t c2 -f Containerfile2|| break;buildah rmi c2;done
Within 30-60s, window 1 will barf:
or
The
rmi
seems important; I can't get it to fail (at least not within my patience tolerance of ~10m) if I omitrmi
from either loop.Testing with
podman
fails MUCH faster than buildah, for reasons I don't understand, and also fails sometimes in window 2. Buildah only fails in window 1.This is blocking parallelization of podman test
070-build
and I bet this is one of the uncategorized weirdnesses I've seen in #5552 but didn't follow up on.The text was updated successfully, but these errors were encountered: