Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jansson JSON library #139

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

saschagrunert
Copy link
Member

This is the first step in migrating from yajl to jansson. We now enable to link it in the same way and add it as dependency to the project.

Q: Should we merge this into a dedicated development branch or is it fine to directly target main?

Refers to #138

This is the first step in migrating from yajl to jansson. We now enable
to link it in the same way and add it as dependency to the project.

Signed-off-by: Sascha Grunert <[email protected]>
@saschagrunert
Copy link
Member Author

@giuseppe
Copy link
Member

great work!

Can we develop it in a separate branch until we are able to build crun from it?

@saschagrunert
Copy link
Member Author

great work!

Can we develop it in a separate branch until we are able to build crun from it?

Thank you! Do you mind creating one so that I can switch the merge base in this PR?

@giuseppe
Copy link
Member

created the branch switch-to-jansson

@saschagrunert saschagrunert changed the base branch from main to switch-to-jansson October 17, 2024 08:44
@saschagrunert
Copy link
Member Author

created the branch switch-to-jansson

Thanks, I switched the base of this PR.

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe giuseppe merged commit 388c91b into containers:switch-to-jansson Oct 17, 2024
6 checks passed
@saschagrunert saschagrunert deleted the add-jansson branch October 17, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants