Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please support --module feature in quadlet #20246

Closed
mhjacks opened this issue Oct 3, 2023 · 5 comments · Fixed by #20253
Closed

Please support --module feature in quadlet #20246

mhjacks opened this issue Oct 3, 2023 · 5 comments · Fixed by #20253
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. quadlet

Comments

@mhjacks
Copy link

mhjacks commented Oct 3, 2023

Feature request description

Podman now supports a module option to enable setting multiple containers.conf level options. Quadlet should support using this feature as well.

Suggest potential solution

Add the necessary code in the quadlet config file and in constructing podman commands to enable its usage

Have you considered any alternatives?

The PodmanArgs catch-all may work for some cases, but according to the community discussion on 10/3/2023 the order of command line args is very important; --module options need to be set early in the command line

Additional context

No response

@mhjacks mhjacks added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 3, 2023
@vrothberg
Copy link
Member

Thanks for opening the issue, @mhjacks.

As so often, I wonder about the right name of the option. We opted for --module instead of --containers-conf-module to keep the name short. But in Quadlet, I feel like ContainersConfModule is probably the right choice.
@rhatdan @ygalblum WDYT?

@sanmai-NL
Copy link
Contributor

--module is too short in my mind, even for the original option. It confused me upon reading the release notes.

@vrothberg
Copy link
Member

--module is too short in my mind, even for the original option. It confused me upon reading the release notes.

Thanks for the feedback, @sanmai-NL. Are the --help message and the docs sufficiently clear? I'm happy to improve but probably need an outside perspective.

@rhatdan
Copy link
Member

rhatdan commented Oct 5, 2023

I think we are bike shedding.
Either

ConfModule
Module

ContainersConfModule seems like a stutter, since you are in the [containers] section. (Although will this work in a .kube, .volume, .network file?

@vrothberg
Copy link
Member

@rhatdan please look at the PR #20253. We're already on ContainersConfModule. IMO it doesn't hurt in a write-once file to be explicit.

@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Jan 8, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. quadlet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants