Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libpod: change the default rootless cgroup path parent #24301

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

libpod: change the default rootless cgroup path parent #24301

wants to merge 1 commit into from

Conversation

rpigott
Copy link

@rpigott rpigott commented Oct 16, 2024

user.slice is a poor choice of slice name to put containers in. There is no direct conflict with the system user.slice, but it may still be easily confused by humans and isn't descriptive of its purpose. After user.slice, user-$UID.slice, user@$uid.service, we don't need another user.slice if we can avoid it.

Let's change user.slice to containers.slice to better represent its usage and help disambiguate it from a slew of user cgroups.

Does this PR introduce a user-facing change?

None

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rpigott
Once this PR has been reviewed and has the lgtm label, please assign mheon for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rpigott rpigott changed the title libpod: change the default cgroup path parent libpod: change the default rootless cgroup path parent Oct 16, 2024
@Luap99
Copy link
Member

Luap99 commented Oct 17, 2024

@giuseppe PTAL

@giuseppe giuseppe added the No New Tests Allow PR to proceed without adding regression tests label Oct 17, 2024
@giuseppe
Copy link
Member

there is no particular reason for using user.slice so I am ok if we want to change it.

Please adjust all the other occurrences of user.slice in the code, documentation and tests

@giuseppe
Copy link
Member

the changes in containers/common must happen in that repository and later vendor the changes in Podman

@Luap99
Copy link
Member

Luap99 commented Oct 21, 2024

IS there be a chance the renaming breaks backwards compatibility with previously created/running containers?

@rpigott
libpod: change the default rootless cgroup path parent
e6f3027 
user.slice is a poor choice of slice name to put containers in. There is
no direct conflict with the system user.slice, but it may still be
easily confused by humans and isn't descriptive of its purpose. After
user.slice, user-$UID.slice, user@$uid.service, we don't need another
user.slice if we can avoid it.

Let's change user.slice to container.slice to better represent its
usage and help disambiguate it from a slew of user cgroups.

Signed-off-by: Ronan Pigott <[email protected]>
@github-actions GitHub Actions
Copy link

A friendly reminder that this PR had no activity for 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
No New Tests Allow PR to proceed without adding regression tests release-note-none stale-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rpigott @Luap99 @giuseppe