Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💡 Proposal - onOpenStateChanged callback for Datepicker component #2603

Open
mxilievski opened this issue Oct 31, 2023 · 1 comment
Open

💡 Proposal - onOpenStateChanged callback for Datepicker component #2603

mxilievski opened this issue Oct 31, 2023 · 1 comment
Labels
needs review Proposal/bug that needs to be reviewed by maintainers proposal stale Used to mark when there was no activity for a set period of time

Comments

@mxilievski
Copy link

Forma 36 contribution proposal

The problem

The Datepicker component doesn't provide any signal whether the popover(Calendar) has been opened or closed. This callback function is crucial to include this component in a popup and to be able to set the window height dynamically.

The proposed solution

Add onOpenStateChanged: (isOpen: boolean | undefined) => void callback function that we can utilise.

Breaking changes
@mxilievski mxilievski added needs review Proposal/bug that needs to be reviewed by maintainers proposal labels Oct 31, 2023
@mxilievski mxilievski changed the title 💡 Proposal - 💡 Proposal - onOpenStateChanged callback for Datepicker component Oct 31, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

Marking issue as stale since there was no activity for 30 days

@github-actions github-actions bot added the stale Used to mark when there was no activity for a set period of time label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs review Proposal/bug that needs to be reviewed by maintainers proposal stale Used to mark when there was no activity for a set period of time
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mxilievski