Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] experiment geist font #2837

Closed
wants to merge 127 commits into from
Closed

Conversation

Lelith
Copy link
Collaborator

@Lelith Lelith commented Jul 30, 2024

experiment for how we could introduce geist font coming from forma36.

denkristoffer and others added 30 commits July 17, 2024 15:21
* feat: add v5 option to codemod that install v5-icons-alpha

* feat: add v5/icons codemod

* refactor: remove v4 and color tokens transformers

* refactor: update utils folder

* refactor: update utils and add jsdocs to functions

* refactor: update readme and remove v4 support

* refactor: run git check on provided path if present

* chore: update help text on codemods

* refactor: update new icon names

* fix: update mapping (#2728)

Co-authored-by: Renato Massao Yonamine <[email protected]>

---------

Co-authored-by: Kristoffer <[email protected]>
* feat: update v5 icons codemod remove variant prop and update size props

* chore: update version of codemod

* chore: remove unnecessary dependency
cf-remylenoir and others added 17 commits July 17, 2024 15:38
…tentful/forma-36 into CFISO-1695-layout-increase-max-width
* feat: change styling of upper navigation

* style: apply light color schema for bottom navbar

* style: apply light color schema for loading skeleton

* chore: rename classes to be more meaningful

* chore: remove unused import

* fix: adjust component imports

* style: add hover style for avatar

* style: adjust position and add border to notification

* chore: remove unused code

* style: fix border styling

* style: fix right side spacing

* chore: create 5.0.0-alpha.0 version

* fix: remove negative visual space between switcher elements

* fix: change to non opaque color to avoid color blending

* chore: remove unused import

* feat: adjust highlight colors

* feat: update icon colors

* feat: polish spacings

* feat: unify focus glow styles

* feat: adjust sizing, spacings, focus styles

* feat: adjust skeleton

* fix: switcher item positioning, focus style

* fix: replace old icon

* fix: replace old icon

* build: bump version from release

* feat: new variant for navbar account notif [Light Navigation] (#2751)

* feat: introduce new notification 'info' variant for NavbarAccount

* chore: bump version

* chore: use latest versions

* feat: introduce size variants for light navbar (#2760)

* feat: set maxWidth for navbar

* feat: enable wide and fullscreen variants

* chore: remove unused import

* feat: only limit the content width not the components

* chore: new alpha release

* refactor: apply avatar changes to light navbar (#2770)

* chore: new alpha release

* feat: move logo out of navbar switcher (#2779)

* build: bump to latest icon + icons

* fix(navbar-switcher): require children

* chore: alpha.9

* fix: icons and utils

* chore: update lock

* fix: alpha.11

This reverts commit 1d1c5f7.

* feat: update navigation item style (#2783)

* feat: single line navigation (#2785)

* feat: refactor Navbar.Item

The components for Help and Search are obsolete and can be solved with the updated NavbarItem

* feat: render everything in a single line

* chore: update story example

* fix: adjust marginleft for icon-only links

* fix: do not show separation bar

* feat: adjust spacing of main navigation

* feat: change Navbar Prop API

* chore: update prop names

* chore: reset npm dev configurator

* feat: remove TopbarItem

only Item should be used

* chore: improve style selector

* chore: add label for Account menu

* feat: use semantic meaningful html tag
fix: merge issues for stories

* chore: pre-release "5.0.0-alpha.16"

* chore: change type definition

* fix: make isActive a optional prop

* chore: reset package-lock file
chore: fix package-lock

* chore: fixing package json after rebase

* feat: improve accessibility

* chore: update dependencies

* chore: release f36-navbar-5.0.0-alpha.17

* chore: release "5.0.0-alpha.18"

* feat: adjust switcher position and style (#2803)

Co-authored-by: Kathrin <[email protected]>

* feat: alpha.19

* fix: add color coding to environment icon

* chore: release v "5.0.0-alpha.20"

* fix(navbar): centred env icon (#2804)

* feat: alpha.21

* fix: navbar switcher colour (#2809)

* feat: alpha.22

* feat: increase hit area for navigation buttons [CFISO-1555] (#2810)

* feat: increase hit area for navigation buttons

* Update packages/components/navbar/src/utils.styles.ts

Co-authored-by: Kristoffer <[email protected]>

* refactor: remove unnecessary elements

---------

Co-authored-by: Kristoffer <[email protected]>

* chore: release navbar-alpha.23

* fix: navbar rendering on website (#2811)

* feat: improve responsiveness for navigation [CFISO-1555] (#2805)

* refactor: render navbar complete as fullscreen on storybook

* feat: add mobile navigation to complete story

* refactor: improve responsiveness on navbar

* feat: add separate story for responsiveness

* chore: update to latest version

* feat: hide secondary nav children except search

* docs: use only navbar compound elements

* feat: prevent overflow of submenu on mobile

* feat: prevent header overflow with long space names

* feat: avoid overflow on small desktop screens

* feat: increase icon size for mobile devices

---------

Co-authored-by: Kathrin <[email protected]>

* chore: version update

* docs: fix story width

* chore: new version 5.0.0-alpha.24

* feat(_avbarswitcher): pass aria label prop

* feat(navbar): new alpha version

---------

Co-authored-by: Rémy Lenoir <[email protected]>
Co-authored-by: Bohdan Hutsol <[email protected]>
Co-authored-by: Renato Massao Yonamine <[email protected]>
Co-authored-by: Renato Massao Yonamine <[email protected]>
Co-authored-by: Kristoffer <[email protected]>
Co-authored-by: Rémy Lenoir <[email protected]>
Co-authored-by: Stephan Leece <[email protected]>
…ax-width

feat(layout): increase max width of wide and narrow variants
@Lelith Lelith requested review from denkristoffer and massao July 30, 2024 06:21
Copy link

vercel bot commented Jul 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ❌ Failed (Inspect) Jul 30, 2024 6:21am

Copy link

changeset-bot bot commented Jul 30, 2024

⚠️ No Changeset found

Latest commit: 44eb184

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package "@contentful/f36-components" depends on the ignored package "@contentful/f36-avatar", but "@contentful/f36-components" is not being ignored. Please add "@contentful/f36-components" to the `ignore` option.
The package "@contentful/f36-components" depends on the ignored package "@contentful/f36-image", but "@contentful/f36-components" is not being ignored. Please add "@contentful/f36-components" to the `ignore` option.
The package "@contentful/f36-components" depends on the ignored package "@contentful/f36-header", but "@contentful/f36-components" is not being ignored. Please add "@contentful/f36-components" to the `ignore` option.

Copy link

Marking pull request as stale since there was no activity for 30 days

@github-actions github-actions bot added the stale Used to mark when there was no activity for a set period of time label Sep 16, 2024
@github-actions github-actions bot removed the stale Used to mark when there was no activity for a set period of time label Oct 24, 2024
Copy link

Marking pull request as stale since there was no activity for 30 days

@github-actions github-actions bot added the stale Used to mark when there was no activity for a set period of time label Nov 23, 2024
@Lelith
Copy link
Collaborator Author

Lelith commented Nov 29, 2024

experiment no longer needed

@Lelith Lelith closed this Nov 29, 2024
@Lelith Lelith deleted the experiment/new_font_1665 branch November 29, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Used to mark when there was no activity for a set period of time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants